Repository navigation
Type brew audit options instead of **options - #24523
Merged
Merged
Conversation
- `FormulaAuditor.new` and `Style.check_style_json` were called with splatted hashes. `.compact` erased the formula hash's shape and the cop keys were added after the literal, so Sorbet checked neither and a mistyped keyword would only fail at runtime. - `.compact` was a no-op: every Boolean is non-nil and `only`, `except` and `style_offenses` already default to `nil`. - `--only-cops`, `--new`, `--except-cops` and `--strict` still select the same cops as before, now covered by `dev-cmd/audit_spec.rb`. - Drop `FormulaAuditor`'s `display_cop_names:` keyword: nothing has passed it since `--display-cop-names` became a hidden no-op in 2023.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormulaAuditor.newandStyle.check_style_jsonsobrew typecheckcatches a mistyped keyword..compactand keys added after the hash literal hid them from Sorbet, so a typo only failed at runtime.FormulaAuditor'sdisplay_cop_names:, which nothing has passed since--display-cop-namesbecame a hidden no-op.--only-cops,--except-cops,--newand--strictselect in unit tests.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code with Opus 5.5, with local review and testing.