Repository navigation
cask/dsl: store lone intel and x86_64 sha256 - #24517
Merged
Merged
Conversation
- `sha256` treated a call with only `intel:` or only `x86_64:` as a getter because the check used `||` instead of `&&` - the checksum was dropped silently and `cask.sha256` stayed `nil` - add examples for both keywords
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sha256dropping a checksum given only asintel:orx86_64:, which leftcask.sha256asniland madebrew auditreporta sha256 stanza is required.&&instead of||in the check that decides whethersha256is being read or set.intel:checksum and a lonex86_64:checksum.brew ruby -e 'Homebrew::SimulateSystem.with(os: :macos, arch: :intel) { p Cask::Cask.new("foo") { sha256 intel: "a" * 64 }.sha256 }', which printsnilbefore the fix.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code with Sonnet 5.5 and Opus 5.5, with local review and testing.