Repository navigation
update-report: warn about branches after report - #24486
Conversation
- The branch warning came straight before the formula and cask report, which then read as its consequence although they are unrelated - Keep the warnings above the blank line ending an auto-update's report
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
|
Following up on the review Harald OK'd by email.
|
On a feature branch,
brew upgradeprinted this, and it looked like being on a branch was why there were no changes:The two are unrelated. The warning from #24421 is about the Homebrew/brew repository and the last line is the formula and cask report, which prints the same on
main.This prints the branch warnings after the report, so nothing follows them that looks like a consequence:
The wording is unchanged and they still only print when the upstream branch moved. They stay above the blank line that ends an auto-update's report, which moves below them. With
HOMEBREW_DISABLE_LOAD_FORMULAset,update-reportreturns before reaching them, so the Homebrew/brew warning no longer prints there, matching the tap warnings.To reproduce:
brew developer oncd "$(brew --repository)" && git switch -c my-branch origin/main~10 && git branch -f main origin/main~10brew updatebrew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code (Claude Opus 5.5) wrote the change and its specs and verified them. Both new specs fail without the change and pass with it. It ran
brew update-report --auto-updatein a terminal with the before and after revisions set to confirm the order above and ranbrew lgtm, which passes.