You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Measure maintainer access used to help others - #24456
Have you checked for other open Pull Requests for the same change?
Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
Have you explained why you'd like these changes included, not just what they do?
For bug fixes, have you given step-by-step brew commands to reproduce the bug?
Have you written new tests (excluding integration tests)? Here's an example.
Have you successfully run brew lgtm (style, typechecking and tests) locally?
I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.
Codex with GPT 6 Astra at High effort, with local review and testing.
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: eb6476e6-1aa1-4d1c-ba96-acd93bcee38e
Commits
Reviewing files that changed from the base of the PR and between 9a0b178 and c6cc61e.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
New Features
Added a --maintainer-exempt option to exclude specified GitHub usernames from Maintainer inactivity removal. Lead Maintainer activity requirements still apply.
Maintainer activity reports now count verified approvals, qualifying pull request merges and issue closures, and can include former GitHub usernames.
Changes
Updated activity thresholds and clarified contribution criteria and reporting requirements. Historical reports using previous criteria must be regenerated.
Reports now stop merge and approval checks once activity thresholds are met.
Improved handling of GitHub rate limits with automatic retries.
The Maintainer contribution report now counts verified merges, approvals and issue closures. It applies updated activity thresholds, supports Maintainer exemptions and changes report columns. GitHub rate-limit handling now supports secondary-limit retries.
Changes: Maintainer activity reporting
Layer / File(s)
Summary
Report options and criteria Library/Homebrew/dev-cmd/contributions.rb, Library/Homebrew/sorbet/rbi/dsl/homebrew/dev_cmd/contributions.rbi
Adds --maintainer-exempt and updates Maintainer activity thresholds and report help.
Merger identity and attribution Library/Homebrew/dev-cmd/contributions.rb, Library/Homebrew/test/dev-cmd/contributions_spec.rb
Tracks merger pull requests from Git history and resolves Maintainer identities and aliases.
Applies Maintainer thresholds and exemptions, updates report columns, rejects older report formats, and updates documentation and completions.
Merge Risk: Minimal · previous review 9a0b1
The Maintainer activity report now counts verified merges, approvals and issue closures against the new thresholds, and handles exemptions and former usernames. No concrete merge-blocking risk remains; a rare edge case where a reopened issue is counted twice across months is a possible follow-up.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly summarises the main change: measuring maintainer activity that helps other contributors. It is concise and relevant to the changeset.
Description check
The description is directly related to the changeset. It explains the maintainer report criteria, thresholds, exemptions, caching, rate limits, historical usernames, and validation work.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.
- Count others' merges, verified approvals and separate issue closures
only in maintainer reports, using repository-specific approval rules.
- Exclude authorship, self-merges and duplicate PR or issue credit.
- Emit only relevant activity columns in maintainer reports while
retaining broader contribution columns in non-maintainer mode.
- Set quarterly thresholds to 40 overall and 20 in two repositories.
- Record Maintainer exemptions without waiving Lead requirements.
- Normalise exemption aliases and warn about unmatched usernames
without blocking historical or filtered reports.
- Verify non-self merges in cached batches until activity is known.
- Cache unavailable PRs without blocking settled activity assessments.
- Keep merger identities independent of contributors' PR commits.
- Resolve known historical usernames for searches and role history.
- Reuse approval history across periods and stop unnecessary API pages.
- Honour secondary rate limits with bounded exponential backoff.
- Reject older report criteria before assessing maintainer roles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at High effort, with local review and testing.