Skip to content

Measure maintainer access used to help others - #24456

Merged
MikeMcQuaid merged 1 commit into
mainfrom
maintainer-activity-criteria
Nov 4, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
maintainer-activity-criteria

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Count others' merges, verified approvals and separate issue closures only in maintainer reports, using repository-specific approval rules.
  • Exclude authorship, self-merges and duplicate PR or issue credit.
  • Emit only relevant activity columns in maintainer reports while retaining broader contribution columns in non-maintainer mode.
  • Set quarterly thresholds to 40 overall and 20 in two repositories.
  • Record Maintainer exemptions without waiving Lead requirements.
  • Verify non-self merges in cached batches until activity is known.
  • Cache unavailable PRs without blocking settled activity assessments.
  • Keep merger identities independent of contributors' PR commits.
  • Resolve known historical usernames for searches and role history.
  • Reuse approval history across periods and stop unnecessary API pages.
  • Honour secondary rate limits with bounded exponential backoff.
  • Reject older report criteria before assessing maintainer roles.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at High effort, with local review and testing.


@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eb6476e6-1aa1-4d1c-ba96-acd93bcee38e
Commits

Reviewing files that changed from the base of the PR and between 9a0b178 and c6cc61e.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • New Features
    • Added a --maintainer-exempt option to exclude specified GitHub usernames from Maintainer inactivity removal. Lead Maintainer activity requirements still apply.
    • Maintainer activity reports now count verified approvals, qualifying pull request merges and issue closures, and can include former GitHub usernames.
  • Changes
    • Updated activity thresholds and clarified contribution criteria and reporting requirements. Historical reports using previous criteria must be regenerated.
    • Reports now stop merge and approval checks once activity thresholds are met.
    • Improved handling of GitHub rate limits with automatic retries.

The Maintainer contribution report now counts verified merges, approvals and issue closures. It applies updated activity thresholds, supports Maintainer exemptions and changes report columns. GitHub rate-limit handling now supports secondary-limit retries.

Changes: Maintainer activity reporting

Layer / File(s) Summary
Report options and criteria
Library/Homebrew/dev-cmd/contributions.rb, Library/Homebrew/sorbet/rbi/dsl/homebrew/dev_cmd/contributions.rbi
Adds --maintainer-exempt and updates Maintainer activity thresholds and report help.
Merger identity and attribution
Library/Homebrew/dev-cmd/contributions.rb, Library/Homebrew/test/dev-cmd/contributions_spec.rb
Tracks merger pull requests from Git history and resolves Maintainer identities and aliases.
Verified activity collection
Library/Homebrew/dev-cmd/contributions.rb, Library/Homebrew/utils/github/api.rb, Library/Homebrew/test/dev-cmd/contributions_spec.rb, Library/Homebrew/test/utils/github/api_spec.rb
Checks pull-request authors, approvals and issue closures. Adds rate-limit response handling, retry behaviour and related tests.
Activity assessment and report output
Library/Homebrew/dev-cmd/contributions.rb, Library/Homebrew/test/dev-cmd/contributions_spec.rb, docs/Homebrew-Governance.md, docs/Manpage.md, manpages/brew.1, completions/*
Applies Maintainer thresholds and exemptions, updates report columns, rejects older report formats, and updates documentation and completions.
Merge Risk: Minimal · previous review 9a0b1

The Maintainer activity report now counts verified merges, approvals and issue closures against the new thresholds, and handles exemptions and former usernames. No concrete merge-blocking risk remains; a rare edge case where a reopened issue is counted twice across months is a possible follow-up.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly summarises the main change: measuring maintainer activity that helps other contributors. It is concise and relevant to the changeset.
Description check Passed The description is directly related to the changeset. It explains the maintainer report criteria, thresholds, exemptions, caching, rate limits, historical usernames, and validation work.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e3044563-062b-4c98-a4d3-5efb60eda4a5
Commits

Reviewing files that changed from the base of the PR and between 69bed7b and 9a0b178.

Files selected for processing: 3
  • Library/Homebrew/dev-cmd/contributions.rb
  • Library/Homebrew/test/dev-cmd/contributions_spec.rb
  • docs/Homebrew-Governance.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

@MikeMcQuaid
MikeMcQuaid force-pushed the maintainer-activity-criteria branch from 69bed7b to 9a0b178 Compare November 3, 2026 09:50
- Count others' merges, verified approvals and separate issue closures
  only in maintainer reports, using repository-specific approval rules.
- Exclude authorship, self-merges and duplicate PR or issue credit.
- Emit only relevant activity columns in maintainer reports while
  retaining broader contribution columns in non-maintainer mode.
- Set quarterly thresholds to 40 overall and 20 in two repositories.
- Record Maintainer exemptions without waiving Lead requirements.
- Normalise exemption aliases and warn about unmatched usernames
  without blocking historical or filtered reports.
- Verify non-self merges in cached batches until activity is known.
- Cache unavailable PRs without blocking settled activity assessments.
- Keep merger identities independent of contributors' PR commits.
- Resolve known historical usernames for searches and role history.
- Reuse approval history across periods and stop unnecessary API pages.
- Honour secondary rate limits with bounded exponential backoff.
- Reject older report criteria before assessing maintainer roles.
@MikeMcQuaid
MikeMcQuaid force-pushed the maintainer-activity-criteria branch from 9a0b178 to c6cc61e Compare November 3, 2026 10:50

@issyl0 issyl0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the clarifications!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit b090520 Nov 4, 2026
55 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the maintainer-activity-criteria branch November 4, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

⌂ 换网址