You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have you checked for other open Pull Requests for the same change?
Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
Have you explained why you'd like these changes included, not just what they do?
For bug fixes, have you given step-by-step brew commands to reproduce the bug?
Have you written new tests (excluding integration tests)? Here's an example.
Have you successfully run brew lgtm (style, typechecking and tests) locally?
I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.
No actionable comments were generated in the recent review.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 6326d3ac-bacc-445b-b75d-1494e4d27bbd
Commits
Reviewing files that changed from the base of the PR and between c6075ba and 6f9bec9.
Files selected for processing: 1
docs/Rakefile
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.
Summary
Summary by CodeRabbit
Chores
Updated documentation checks to flag bare URLs at the start of a line or directly after any non-whitespace character.
The documentation lint task now skips subsequent checks when no Markdown files are tracked and reports an error if the tracked-file lookup fails.
General Markdown linting excludes the designated index and manpage files; their separate checks remain in place. Filenames are safely handled in the review-date check.
The documentation lint configuration now matches URLs at the start of a line. The lint task checks whether tracked Markdown files can be listed, filters files for general linting, and shell-escapes paths for the missing-frontmatter check.
Changes: Documentation lint
Layer / File(s)
Summary
Lint task file detection docs/Rakefile
The task requires Ruby’s English and shellwords libraries. It raises an error if listing tracked Markdown files fails and skips linting if the list is empty. It excludes Manpage.md, docs/index.md, and index.md from general linting. It shell-escapes paths for the missing-frontmatter check. The separate index.md lint remains.
HB034 URL matching docs/.mdl_ruleset.rb
The HB034 pattern now matches HTTP and HTTPS URLs at the start of a line or after a non-whitespace character.
Merge Risk: Minimal · up to 6f9be
The lint task now fails on Git listing errors and avoids silently linting no files; the URL rule also covers URLs at the start of a line.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly summarises the documentation lint fixes in the changeset, including edge cases in URL detection and Markdown directory handling.
Description check
The description directly explains the two documentation lint changes and relates to the changeset.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The current regex lets See (https://example.test) pass the docs lint task. This violates the documented prohibition on bare URLs and narrows the MD034 behaviour that HB034 replaces.
- Reject bare URLs at the start of a line.
- Skip empty Markdown directories and report Git failures.
- Reuse the checked file list for every Markdown lint check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](/p/https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?