Skip to content

Correct documentation and JSON help - #24437

Merged
MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
hezhizhen:documentation-accuracy
Nov 2, 2026
Merged

MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
hezhizhen:documentation-accuracy

Conversation

@hezhizhen

Copy link
Copy Markdown
Contributor

Summary

Correct four discrepancies between the documentation and current behaviour:

- Cursor launches "brew mcp-server" as one executable
+ Cursor uses "brew" with ["mcp-server"] over stdio
- Bundle attempts to upgrade every package
+ Bundle upgrades where supported; installed Go/Cargo/uv are not checked for updates
- Cask policies apply only on macOS
+ Cask policies also apply to casks supporting Linux
- outdated --json defaults to v1
+ v2 is the default and only supported version

Regenerate the manpage and fish/zsh completion descriptions from the
outdated command source.

Evidence

To see the outdated JSON discrepancy before this change:

  1. Run ./bin/brew outdated --help: it describes v1 as the default.
  2. Run ./bin/brew outdated --json=v1: it reports that v1 is no longer
    supported.

After this change, the help and generated descriptions consistently state
v2. The version-selection behaviour is unchanged.

The Cursor example follows the
official STDIO configuration.
All four MCP JSON examples parse successfully.

Validation:

  • ./bin/brew generate-man-completions
  • ./bin/brew lgtm --online
  • ./bin/brew style docs: 102 files, no offences
  • Vale: 97 Markdown files, no findings
  • Jekyll build and bundle exec rake lint
  • bundle exec rake test: 146 external links and 495 internal links checked

Merge Danger

Door: two-way. Reverting requires no migration.

Blast Radius: small. Changes are limited to documentation, help strings
and generated command descriptions; command behaviour is unchanged.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

No new test files were added because this only changes documentation and
help strings. Existing command tests, JSON parsing and the documentation
checks validate the change.

OpenAI Codex assisted with investigation, the documentation edits and this
description. The contributor reviewed the patch before authorising
submission and will handle maintainer discussion directly.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 03d998ef-2f68-4ab9-8af2-22386a9d7511
Commits

Reviewing files that changed from the base of the PR and between 3190634 and 5725b94.

Files selected for processing: 1
  • docs/Brew-Bundle-and-Brewfile.md
Files skipped from review as they are similar to previous changes: 1
  • docs/Brew-Bundle-and-Brewfile.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that brew outdated --json supports only version 2 in command descriptions, shell completions and documentation.
    • Updated upgrade guidance to note that installed Go, Cargo and uv packages are not checked for newer versions, and that disabling upgrades does not pin versions or provide lock-file support.
    • Clarified that relevant cask settings apply on macOS and Linux.
    • Updated the Cursor MCP server configuration example.

Help text, completions, and manpages now describe outdated JSON v2 as the only supported format. Documentation updates also clarify brew bundle upgrade behaviour, cask platform scope, and Cursor MCP configuration.

Changes: Outdated JSON format

Layer / File(s) Summary
Update outdated JSON descriptions
Library/Homebrew/cmd/outdated.rb, completions/fish/brew.fish, completions/zsh/_brew, docs/Manpage.md, manpages/brew.1
The command description, completions, and manpages identify v2 as the only supported JSON format.

Brew bundle upgrade guidance

Layer / File(s) Summary
Clarify brew bundle upgrade behaviour
docs/Brew-Bundle-and-Brewfile.md
The guide states that upgrades are attempted where supported and excludes installed Go, Cargo, and uv packages from newer-version checks. It clarifies that disabling upgrades does not pin versions or add lock-file support.

Cask platform scope

Layer / File(s) Summary
Update cask platform qualification
docs/Homebrew-Package-Policies.md
The policy text covers macOS and Linux when the cask supports the platform.

Cursor MCP configuration

Layer / File(s) Summary
Update Cursor configuration example
docs/MCP-Server.md
The example sets the command to brew, passes mcp-server as an argument, and sets the transport to stdio.
Merge Risk: Minimal · up to 5725b

The documentation wording concern is fixed, and no remaining issue is identified that would prevent merging after normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the main changes to documentation and JSON help. It is concise and related to the changeset.
Description check Passed The description accurately covers all four documentation and help-text corrections, their scope, and the reported validation results.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 84f9ddb0-1314-443a-b896-d42671e9a2d4
Commits

Reviewing files that changed from the base of the PR and between bf464f5 and 3190634.

Files selected for processing: 8
  • Library/Homebrew/cmd/outdated.rb
  • completions/fish/brew.fish
  • completions/zsh/_brew
  • docs/Brew-Bundle-and-Brewfile.md
  • docs/Homebrew-Package-Policies.md
  • docs/MCP-Server.md
  • docs/Manpage.md
  • manpages/brew.1

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Comment thread docs/Brew-Bundle-and-Brewfile.md Resolved
- Match Cursor's stdio configuration and Linux cask policy scope.
- Explain Bundle's upgrade limits and clarify its opt-out instructions.
- Remove obsolete JSON v1 guidance and regenerate command descriptions.
@hezhizhen
hezhizhen force-pushed the documentation-accuracy branch from 3190634 to 5725b94 Compare November 2, 2026 07:00

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Nov 2, 2026
Merged via the queue into Homebrew:main with commit e02e854 Nov 2, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址