You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have you checked for other open Pull Requests for the same change?
Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
Have you explained why you'd like these changes included, not just what they do?
For bug fixes, have you given step-by-step brew commands to reproduce the bug?
Have you written new tests (excluding integration tests)? Here's an example.
Have you successfully run brew lgtm (style, typechecking and tests) locally?
I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.
Codex with GPT 6 Astra at Extra High effort, with local review and testing.
Sponsor recognition now includes eligible contributions from GitHub, Patreon and Open Collective, with names and logos shown according to applicable recognition tiers.
Major and minor release notes now thank listed sponsors.
The README now links to sponsorship information and displays sponsor details and release-sponsor logos.
Bug Fixes
Scheduled sponsor-list updates can continue alongside other updates if sponsorship data cannot be fetched, while reporting the failure.
Running the sponsor update when the README has no changes now completes without failing.
Documentation
Added guidance on sponsoring Homebrew and how sponsor recognition works.
The PR adds sponsorship collection from GitHub, Patreon and Open Collective. It updates sponsor listings in the README, adds sponsor acknowledgements to major and minor release notes, changes scheduled update handling, and adds sponsorship documentation. It also updates maintainer listings.
Changes: Sponsor recognition
Layer / File(s)
Summary
Sponsor data and collection Library/Homebrew/utils/github.rb, Library/Homebrew/utils/sponsors.rb, Library/Homebrew/test/utils/github_spec.rb, Library/Homebrew/test/utils/sponsors_spec.rb
GitHub sponsorship data now includes one-time tiers, tier descriptions and start dates. The new Sponsors module collects eligible records from GitHub, Patreon and Open Collective. Tests cover provider eligibility, benefit periods and historical tier descriptions.
Sponsor records and README output Library/Homebrew/dev-cmd/update-sponsors.rb, Library/Homebrew/test/dev-cmd/update-sponsors_spec.rb, completions/fish/brew.fish, completions/zsh/_brew, README.md
brew update-sponsors combines provider records and updates the README with platform-specific sponsor names and logo entries. It applies tier, ordering, name-escaping and URL rules. The command descriptions now refer to sponsors, and tests cover output and failure cases. The README links to sponsorship information and lists supporters by platform.
The workflow provides the Patreon token and continues other update commands if sponsor updates fail. A later step reports the failure and exits with a non-zero status. The scheduled issue body points to the workflow log and notes that some updates may have completed.
Major and minor releases fetch origin and read sponsor names from origin/main:README.md. The release command prints a thank-you when the README contains sponsor names. Tests cover attribution conditions and event order.
Sponsorship information docs/Sponsoring-Homebrew.md, docs/index.md
The new guide describes contribution use, recognition criteria and durations, and the update process. The documentation index links to the guide.
Maintainer listings
Layer / File(s)
Summary
Maintainer and author lists README.md, docs/Manpage.md, manpages/brew.1
The README and manpage author and maintainer lists are updated. The generated manpage date changes to November 2026.
Merge Risk: Moderate · up to 94f6c
Some sponsors may receive incorrect benefits, while automated README updates can create unnecessary reorder-only commits. These issues should be addressed before merging.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly summarises the main change: applying sponsor benefits across multiple platforms.
Description check
The description directly explains the sponsorship changes, recognition rules, platform integrations, documentation, and testing.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
123-129: Trivial · Maintainability & Code Quality · Low value
Split the failure and success cases into separate examples.
The failure branch has two expect calls (Lines 125 and 126). The example also branches on failure.
The repository learning requires one expect per unit test. The before setup here is trivial, so the exception does not apply. Use two examples, each with one expect. Use readme.read in a separate example, or a before hook for the shared stubs.
Based on learnings: "Use a single expect per unit test; combine expectations only in integration tests or when the before setup is non-trivial."
Source: Learnings
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 55847302-c421-42c2-a774-ed7140e5e580
Commits
Reviewing files that changed from the base of the PR and between 8a17c20 and 3eb1254.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Additional comments: 1
Library/Homebrew/utils/sponsors.rb-136-139: 1
136-139: Minor · Stability & Availability · Quick win
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Reject a repeated Patreon pagination cursor.
The loop stops only when meta.pagination.cursors.next is blank. If Patreon returns the same cursor that the request just used, the loop sends the same request again without end. The scheduled workflow then hangs until the job times out. Raise an error when the cursor does not change.
Proposed fix
cursor = result.dig("meta", "pagination", "cursors", "next")
break if cursor.blank?
+ raise "Patreon returned a repeated pagination cursor." if cursor == parameters["page[cursor]"]
parameters["page[cursor]"] = cursor
Based on learnings: reject responses where the server reports more pages but the cursor is unchanged, to prevent infinite loops.
Source: Learnings
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 764b0b12-52ed-411e-9cad-7c3e7f257546
Commits
Reviewing files that changed from the base of the PR and between 3eb1254 and 9f26f12.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 61298497-eebf-4bd6-9bc9-be0866a270ec
Commits
Reviewing files that changed from the base of the PR and between 012ca61 and f49734c.
Files selected for processing: 3
README.md
docs/Manpage.md
manpages/brew.1
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
sort_by does not guarantee a stable order in Ruby. Sponsors with the same monthly_amount can be placed in an order the sort does not define. The groups recurring and one-time sponsors… example depends on that order. Three sponsors have amount 1000, and the spec expects Shared Sponsor before Gift Sponsor. An explicit index tie-breaker keeps the input order. This matches the expected output and makes the README order independent of the sort implementation.
♻️ Proposed fix
- sponsors.sort_by { |s| -s[:monthly_amount] }.each do |s|+ sponsors.sort_by.with_index { |s, index| [-s[:monthly_amount], index] }.each do |s|
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 1c8c38d8-6ce6-4342-845e-0910dad500bb
Commits
Reviewing files that changed from the base of the PR and between 6f89a38 and 08dfffe.
Files skipped from review as they are similar to previous changes: 1
README.md
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 84df920e-7360-45e2-8f90-cec573b68608
Commits
Reviewing files that changed from the base of the PR and between 70c6337 and 8654253.
Files selected for processing: 3
README.md
docs/Manpage.md
manpages/brew.1
Files skipped from review as they are similar to previous changes: 1
README.md
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
- Preserve retired tiers and contributions before 30 October 2026,
with twelve months of recognition for eligible one-time gifts.
- Validate sponsorship amounts across all providers and gift types.
- Import Patreon and Open Collective sponsorships and profile images.
- List sponsors by platform with logo sponsors first, sorting each
group by monthly contribution and linking names alongside logos.
- Remove static service acknowledgements from `README.md` and link
other supporters to public sponsor lists or their platform page.
- Fetch origin before generating major/minor release notes and read
sponsor acknowledgements from its README.
- Report provider failures after independent workflow updates finish.
- Document sponsorship recognition, funding and project spending.
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
⚠️ Outside diff range comments (1)
Minor · Do not expose one-time tiers to recurring sponsorship matching. · github.rb:457-458
Library/Homebrew/utils/github.rb:457-458 Minor · Data Integrity & Integration · Quick win
Do not expose one-time tiers to recurring sponsorship matching.
GitHub.sponsorships returns recurring sponsorships, but GitHub.sponsorship_tiers exposes one-time tiers at one-twelfth of their annual price. The matcher does not retain a one-time distinction. A recurring sponsorship can therefore match a one-time tier and receive benefits at the wrong amount. Sponsors.github_one_time already supplies the one-time gift's tier description separately, so exclude one-time tiers from this shared list.
Suggested fix
- # Return published tiers with one-time prices expressed as monthly amounts.+ # Return published recurring tiers.
...
- next if tier.nil?+ next if tier.nil? || tier["isOneTime"]- months = tier["isOneTime"] ? 12 : 1- { description: tier.fetch("description"), monthly_amount: tier.fetch("monthlyPriceInDollars") / months }+ { description: tier.fetch("description"), monthly_amount: tier.fetch("monthlyPriceInDollars") }
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 90f47293-6274-4fb7-a7e4-bf8b2572011b
Commits
Reviewing files that changed from the base of the PR and between 1be79ba and 94f6c9c.
Files selected for processing: 3
README.md
docs/Manpage.md
manpages/brew.1
Files skipped from review as they are similar to previous changes: 1
README.md
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](/p/https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.