Skip to content

workflows: use case instead of faux ternary - #24413

Merged
carlocab merged 1 commit into
mainfrom
workflow-use-case
Oct 31, 2026
Merged

carlocab merged 1 commit into
mainfrom
workflow-use-case

Conversation

@carlocab

@carlocab carlocab commented Oct 31, 2026 •

Copy link
Copy Markdown
Member
  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

All by hand.


This is the same change as Homebrew/homebrew-core#322634.


@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 79d1695d-e41b-4ae5-a388-c13ac2dde656
Commits

Reviewing files that changed from the base of the PR and between dfdd803 and 9b83b6a.

Files selected for processing: 1
  • .github/workflows/tests.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated automated build workflows to select an ARM-specific runner for ARM64 builds.
    • Adjusted automated test settings for padded-prefix entries and system-tar configurations.
    • These workflow changes affect project builds and checks; no end-user features or behaviour have changed.

The Docker workflow now uses case() to select a runner by architecture. The test workflow uses case() to set two environment values based on matrix values.

Changes: Workflow expression updates

Layer / File(s) Summary
Update workflow expressions
.github/workflows/docker.yml, .github/workflows/tests.yml
The Docker workflow selects a runner by architecture. The test workflow sets two environment values with case() expressions.
Merge Risk: Minimal · up to 9b83b

The workflow updates preserve runner selection and environment behavior, so the change is mergeable with normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title "workflows: use case instead of faux ternary" matches the main change. The raw summary says the workflow files replace chained &&/|| ternary-style expressions with GitHub Actions `case…
Description check Passed The description states that the PR makes the same change as Homebrew/homebrew-core#322634 and includes the contributing checklist. It does not describe the specific workflow edits, but it relates to t…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "workflows: use case instead of faux ternary" matches the main change. The raw summary says the workflow files replace chained &&/|| ternary-style expressions with GitHub Actions case() expressions in docker.yml and tests.yml. The title is specific, short and descriptive.

Full details: Description check

Explanation

The description states that the PR makes the same change as Homebrew/homebrew-core#322634 and includes the contributing checklist. It does not describe the specific workflow edits, but it relates to the changeset, so the lenient check passes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab
carlocab enabled auto-merge October 31, 2026 20:49
@carlocab
carlocab added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 94d5e12 Oct 31, 2026
53 checks passed
@carlocab
carlocab deleted the workflow-use-case branch October 31, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址