Repository navigation
Honour installed formula rpath preservation - #24402
Conversation
- Read `preserve_rpath` from the installed formula because API metadata omits it and rewriting bundled dylib IDs can overflow their Mach-O headers.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Formula lookup and fallback behaviour Library/Homebrew/keg_relocate.rb, Library/Homebrew/extend/os/mac/keg_relocate.rb, Library/Homebrew/test/keg_spec.rb |
The shared Keg implementation checks the installed formula’s preserve_rpath? value, then falls back to lookup by formula name. It returns false if formula loading raises FormulaUnavailableError. The specs cover installed-formula preference, fallback lookup, and unavailable formulas. |
Priority:
Merge Risk: 
Minimal · up to 60d11
-
The change reads preserve_rpath from the installed formula and falls back to name lookup. No actionable merge-blocking risk remains.
Pre-merge checks: 
4
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Thanks! |
Read
preserve_rpathfrom the installed formula because API metadata omits it and rewriting bundled dylib IDs can overflow their Mach-O headers.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.