Repository navigation
create: Strip trailing dot from GitHub description - #24374
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Trim repository description Library/Homebrew/formula_creator.rb |
FormulaCreator initializes @desc as an empty string, converts a fetched GitHub description to a string and removes trailing full stops, then interpolates @desc directly in the formula template. |
Priority:
Merge Risk: 
2ef90
-
Creation no longer crashes on a null GitHub description. Descriptions ending in multiple dots can still fail the intended audit check, but this is a narrow, previously reported case.
Pre-merge checks: 
-
Check name Status Explanation Description check The description clearly explains that the change removes trailing full stops from GitHub descriptions generated by brew create. It also includes validation commands and the expected audit result.Title check The title clearly and concisely summarises the main change: stripping a trailing full stop from GitHub descriptions. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](/p/https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
7b38e631-4454-4eca-8970-27191a8942e4
-
Library/Homebrew/formula_creator.rb
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
-
5e76068 to
a784ad2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
cf8eb056-0874-4d8d-ad63-2cabd1f8bc43
-
Library/Homebrew/formula_creator.rb
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
-
a784ad2 to
126465d
Compare
Lubricates audit friction: * line 2, col 70: Description shouldn't end with a full stop. Change @desc type to string, because its null is not used anyway.
126465d to
e0a66b7
Compare
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
88c0ab74-6715-4092-a5bc-dc5d8eae1e3a
-
Library/Homebrew/formula_creator.rb
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
-
Lubricates audit friction:
Testing
The message about full stop should not be there.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?