Repository navigation
dev-cmd/bump: search pull requests by short name - #24370
Conversation
`--full-name` was meant only to change how names are displayed, but the same name was passed to the pull request search. For a non-core tap that search used `user/tap/name`, which never matches the pull request titles `bump-*-pr` creates, so neither the duplicate nor the open bump pull request check worked and `brew bump --open-pr` opened duplicate PRs. `Homebrew/actions/bump-packages` passes `--full-name` whenever a name contains a `/`, so this affects every third-party tap using it. The search is already scoped to the tap's repository, so search by the short name instead. Core and cask taps are unaffected because their full names are already the short name.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Version lookup arguments Library/Homebrew/dev-cmd/bump.rb, Library/Homebrew/test/dev-cmd/bump_spec.rb |
retrieve_versions_by_arch and its callers no longer pass a package name. Tests use the updated call signature. |
Pull-request name derivation Library/Homebrew/dev-cmd/bump.rb, Library/Homebrew/test/dev-cmd/bump_spec.rb |
retrieve_pull_requests derives the package name with Livecheck.package_or_resource_name. Callers omit the name argument. Tests cover version matching and lookup of a cask in a non-core tap using its short name. |
Priority:
Merge Risk: 
Minimal · up to 16de0
-
The lookup changes are consistent across production code and tests, with no identified merge-blocking risk.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title names the main change: the pull request search for bump now uses the package short name. It matches the PR objective and the raw summary, which show
retrieve_pull_requestsderiving the short name viaLivecheck.package_or_resource_name. The title is specific and short, and a teammate scanning history would understand the primary change.
Full details: Description check
-
Explanation
The description explains the problem.
--full-namealso changed the pull request search, so non-core taps searched withuser/tap/name, which did not matchbump-*-prtitles. That broke the duplicate and open-PR checks. It states the fix (search by short name), the scope (tap repository, core and cask unaffected), and the impact (third-party taps usingbump-packages). This matches the changeset in bump.rb and bump_spec.rb.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
--full-namewas meant only to change how names are displayed, but the same name was passed to the pull request search. For a non-core tap that search useduser/tap/name, which never matches the pull request titlesbump-*-prcreates, so neither the duplicate nor the open bump pull request check worked andbrew bump --open-propened duplicate PRs.Homebrew/actions/bump-packagespasses--full-namewhenever a name contains a/, so this affects every third-party tap using it.The search is already scoped to the tap's repository, so search by the short name instead. Core and cask taps are unaffected because their full names are already the short name.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude with Opus 5.5 at High effort, with local review and testing.