Skip to content

dev-cmd/bump: search pull requests by short name - #24370

Merged
MikeMcQuaid merged 1 commit into
mainfrom
bump-search-short-name
Oct 28, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
bump-search-short-name

Conversation

@bevanjkay

Copy link
Copy Markdown
Member

--full-name was meant only to change how names are displayed, but the same name was passed to the pull request search. For a non-core tap that search used user/tap/name, which never matches the pull request titles bump-*-pr creates, so neither the duplicate nor the open bump pull request check worked and brew bump --open-pr opened duplicate PRs.

Homebrew/actions/bump-packages passes --full-name whenever a name contains a /, so this affects every third-party tap using it.

The search is already scoped to the tap's repository, so search by the short name instead. Core and cask taps are unaffected because their full names are already the short name.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Claude with Opus 5.5 at High effort, with local review and testing.


`--full-name` was meant only to change how names are displayed, but the
same name was passed to the pull request search. For a non-core tap that
search used `user/tap/name`, which never matches the pull request titles
`bump-*-pr` creates, so neither the duplicate nor the open bump pull
request check worked and `brew bump --open-pr` opened duplicate PRs.

`Homebrew/actions/bump-packages` passes `--full-name` whenever a name
contains a `/`, so this affects every third-party tap using it.

The search is already scoped to the tap's repository, so search by the
short name instead. Core and cask taps are unaffected because their full
names are already the short name.
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c833ebc4-b77c-4d4c-a237-ab2d5998a620
Commits

Reviewing files that changed from the base of the PR and between 20e162d and 16de026.

Files selected for processing: 2
  • Library/Homebrew/dev-cmd/bump.rb
  • Library/Homebrew/test/dev-cmd/bump_spec.rb

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Pull-request lookups now use the short name for casks in non-core taps, improving matching in those repositories.
  • Refactor
    • The bump command now derives package names from the formula or cask when retrieving version and pull-request information, rather than requiring the name to be provided separately.
    • Version-based pull-request matching remains supported.

The bump command no longer requires callers to provide a package name for version and pull-request lookups. Pull-request lookup derives the package name from the formula or cask.

Changes: Bump lookup

Layer / File(s) Summary
Version lookup arguments
Library/Homebrew/dev-cmd/bump.rb, Library/Homebrew/test/dev-cmd/bump_spec.rb
retrieve_versions_by_arch and its callers no longer pass a package name. Tests use the updated call signature.
Pull-request name derivation
Library/Homebrew/dev-cmd/bump.rb, Library/Homebrew/test/dev-cmd/bump_spec.rb
retrieve_pull_requests derives the package name with Livecheck.package_or_resource_name. Callers omit the name argument. Tests cover version matching and lookup of a cask in a non-core tap using its short name.

Priority: Normal

Merge Risk: Minimal · up to 16de0

The lookup changes are consistent across production code and tests, with no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names the main change: the pull request search for bump now uses the package short name. It matches the PR objective and the raw summary, which show retrieve_pull_requests deriving the sho…
Description check Passed The description explains the problem. --full-name also changed the pull request search, so non-core taps searched with user/tap/name, which did not match bump-*-pr titles. That broke the duplica…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the pull request search for bump now uses the package short name. It matches the PR objective and the raw summary, which show retrieve_pull_requests deriving the short name via Livecheck.package_or_resource_name. The title is specific and short, and a teammate scanning history would understand the primary change.

Full details: Description check

Explanation

The description explains the problem. --full-name also changed the pull request search, so non-core taps searched with user/tap/name, which did not match bump-*-pr titles. That broke the duplicate and open-PR checks. It states the fix (search by short name), the scope (tap repository, core and cask unaffected), and the impact (third-party taps using bump-packages). This matches the changeset in bump.rb and bump_spec.rb.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ZhongRuoyu ZhongRuoyu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 130a177 Oct 28, 2026
55 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the bump-search-short-name branch October 28, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址