Repository navigation
info: remove stale installed_as_dependency TODO - #24318
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
MikeMcQuaid
enabled auto-merge
October 21, 2026 16:45
ZhongRuoyu
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew::Cmd::Info.installation_statushas aTODOasking to deprecate reading installed_as_dependency, becauseinstalled_on_request` is the only state needed to render install intent.This is already done. No code outside the tests reads
installed_as_dependencyfrom a receipt any more.Tabignores unknown receipt keys through_unknown, so old receipts that still have the key load fine (the comment intab.rbcalls it "long-removed").installation_statusalready uses onlyinstalled_on_request.This change removes the stale
TODOcomment. No behaviour change.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?AI (Claude Code) helped me find this stale
TODOand check that nothing still readsinstalled_as_dependency.I reviewed the change and ran
brew lgtmlocally.