Skip to content

info: remove stale installed_as_dependency TODO - #24318

Merged
MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
hyuraku:info-drop-stale-todo
Oct 22, 2026
Merged

MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
hyuraku:info-drop-stale-todo

Conversation

@hyuraku

@hyuraku hyuraku commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Homebrew::Cmd::Info.installation_status has a TODO asking to deprecate reading installed_as_dependency, because installed_on_request` is the only state needed to render install intent.

This is already done. No code outside the tests reads installed_as_dependency from a receipt any more. Tab ignores unknown receipt keys through _unknown, so old receipts that still have the key load fine (the comment in tab.rb calls it "long-removed"). installation_status already uses only installed_on_request.

This change removes the stale TODO comment. No behaviour change.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

AI (Claude Code) helped me find this stale TODO and check that nothing still reads installed_as_dependency.
I reviewed the change and ran brew lgtm locally.


@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 628dc54a-63c6-42fc-a64b-4e9c56170499
📥 Commits

Reviewing files that changed from the base of the PR and between 1ef73bb and 479852d.

📒 Files selected for processing: 1
  • Library/Homebrew/cmd/info.rb
💤 Files with no reviewable changes: 1
  • Library/Homebrew/cmd/info.rb

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Removed an outdated internal comment; no user-visible behaviour has changed.

The change removes a TODO comment about deprecating installed_as_dependency from installation_status. Runtime behaviour remains unchanged.

Changes: Installation status

Layer / File(s) Summary
Remove deprecation TODO
Library/Homebrew/cmd/info.rb
The TODO comment about deprecating installed_as_dependency is removed. installation_status still reports status based on installed_on_request.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 47985

This comment-only change is ready to merge after normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: removing the stale installed_as_dependency TODO from info.
Description check Passed The description accurately explains the removal of the stale TODO, confirms that behaviour remains unchanged, and provides relevant validation details.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid enabled auto-merge October 21, 2026 16:45
@MikeMcQuaid
MikeMcQuaid disabled auto-merge October 22, 2026 07:36
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Oct 22, 2026
Merged via the queue into Homebrew:main with commit d0cdf8f Oct 22, 2026
58 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址