Repository navigation
Prefill app and zap in brew create --cask - #24316
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to
|
88bf69f to
59ef862
Compare
59ef862 to
109f015
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
7310b9b9-508c-47ae-90be-6136f73ed2c1
📒 Files selected for processing: 4
Library/Homebrew/dev-cmd/create.rbLibrary/Homebrew/dev-cmd/generate-zap.rbLibrary/Homebrew/test/dev-cmd/create_spec.rbLibrary/Homebrew/test/dev-cmd/generate-zap_spec.rb
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
109f015 to
d2f1788
Compare
- New casks now need a `zap` stanza, which contributors find the most confusing part of a cask. Prefill it by running `brew generate-zap` on an installed copy of the app. - Show `brew generate-zap`'s warnings and errors, e.g. a missing Full Disk Access permission, so contributors know why nothing was prefilled. - The cask name defaults to the download's file name, e.g. `AgentIDE-0.9.11`, not the app's, so unpack the download to find the app instead. Use it to fill in `app`, read its appcast for `livecheck` and find the installed copy. - Only scan an installed copy, so that a generic app name doesn't match unrelated files, and skip suites of apps rather than guess. - Unpacking only helps prefill the template, so warn rather than fail when the download can't be unpacked. - Have `brew generate-zap --name` also match the installed app's bundle identifier, which names most preference and cache files. - Without an installed copy, contributors still need to know how to generate one, so say in the template exactly what to run and list the steps in the Cask Cookbook.
d2f1788 to
1fd644f
Compare
zapstanza, which contributors find the most confusing part of a cask. Prefill it by runningbrew generate-zapon an installed copy of the app.AgentIDE-0.9.11, not the app's, so unpack the download to find the app instead. Use it to fill inapp, read its appcast forlivecheckand find the installed copy.brew generate-zap --namealso match the installed app's bundle identifier, which names most preference and cache files.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?