Repository navigation
cask/audit: reject new casks requiring Rosetta - #24309
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
9e1db610-904a-4918-8ec1-38667f5a67c5
📒 Files selected for processing: 3
Library/Homebrew/cask/audit.rbLibrary/Homebrew/test/cask/audit_spec.rbdocs/Acceptable-Casks.md
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
- macOS 27 is now the latest stable release so, per `docs/Acceptable-Casks.md`, new casks needing Rosetta 2 are no longer acceptable. Error in `audit_rosetta` when a new cask's artifacts are x86_64-only. - Replace the pre-Big Sur guards with an explicit macOS check: Big Sur is the oldest allowed macOS. The `depends_on macos:` guard also skipped every cask without one, as `nil&.maximum_version.to_s` is `""`, which sorts before `"11"`.
a92c720 to
ca73422
Compare
docs/Acceptable-Casks.md, new casks needing Rosetta 2 are no longer acceptable. Error inaudit_rosettawhen a new cask's artifacts are x86_64-only.depends_on macos:guard also skipped every cask without one, asnil&.maximum_version.to_sis"", which sorts before"11".brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude with Opus 5.5 at High effort, with local review and testing.