Skip to content

cask/audit: skip livecheck requirement for :latest - #24297

Merged
MikeMcQuaid merged 1 commit into
mainfrom
fix_livecheck
Oct 19, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
fix_livecheck

Conversation

@bevanjkay

@bevanjkay bevanjkay commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Claude with Opus 5.5 at High effort, with local review and testing.


Summary by CodeRabbit

  • Bug Fixes
    • Casks configured to track the latest version are no longer flagged by the required-livecheck audit. Other existing checks for new casks, official taps and shared audit issues remain unchanged, so the adjustment applies specifically to casks using the latest-version setting. This prevents an unnecessary audit issue for those casks.

- `audit_latest_with_livecheck` forbids a `livecheck` block in casks
  using `version :latest`, so `audit_livecheck_required` could never
  be satisfied by them, e.g. `font-baekmuk` in
  Homebrew/homebrew-cask#295296.
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 863a696c-d584-4495-bd25-4d80d60b67d1
📥 Commits

Reviewing files that changed from the base of the PR and between 8f10429 and 3501d95.

📒 Files selected for processing: 2
  • Library/Homebrew/cask/audit.rb
  • Library/Homebrew/test/cask/audit_spec.rb

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The livecheck-required audit now skips casks with version :latest. A test verifies that the audit helper is not called for a new cask with that version.

Changes: Livecheck-required audit

Layer / File(s) Summary
Skip the check for latest versions
Library/Homebrew/cask/audit.rb, Library/Homebrew/test/cask/audit_spec.rb
The audit returns when the cask version is :latest. A test checks that the livecheck audit helper is not called for a new cask with that version.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 3501d

version :latest casks are exempt from the livecheck-required check, while the separate rule against defining a livecheck for them remains active. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: skipping the livecheck requirement for casks that use version :latest.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 1bb6afa Oct 19, 2026
54 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the fix_livecheck branch October 19, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址