Repository navigation
info: show revision in headline upgrade version - #24271
Merged
MikeMcQuaid merged 1 commit intoOct 16, 2026
Merged
Conversation
HaraldNordgren
marked this pull request as ready for review
October 16, 2026 08:22
Contributor
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
b85511a4-cd0e-4df6-8069-6a52fd0dc243
📒 Files selected for processing: 2
Library/Homebrew/cmd/info.rbLibrary/Homebrew/test/cmd/info_spec.rb
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
- The headline built its upgrade target from `stable.version`, which drops the revision, so a revision bump showed as `2.56.0 → stable 2.56.0`. - Use `formula.pkg_version` when outdated to match the Installed Versions line and what `brew upgrade` installs.
HaraldNordgren
force-pushed
the
info-headline-pkg-version
branch
from
October 16, 2026 08:37
b3cb275 to
4cca545
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a revision bump, the
brew infoheadline drops the revision from the upgrade target, so it looks like an upgrade to the version already installed. It now usespkg_version, matching the Installed Versions line and whatbrew upgradeinstalls.To reproduce, run
brew info gitwithgit2.56.0 installed (the formula is nowrevision 1).Before:
After:
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code (Claude Opus 5.5) traced the cause, wrote the fix and spec change and drafted this description. Verified with
brew typecheck,brew styleon the changed files,brew tests --only=cmd/info(the updated spec fails onmainand passes with the fix) and thebrew info gitbefore/after above, captured on macOS 12.Summary by CodeRabbit