Repository navigation
cask/ci/check: ignore more running Apple apps - #24244
Merged
Merged
Conversation
- Some casks open an Apple app on install or first launch, e.g. `typinator` opens its tutorial `.rtfd` in TextEdit, which fails CI with `com.apple.TextEdit` left running. - Casks have worked around this with `uninstall quit:` stanzas for Help Viewer (`eaglefiler`), Mail (`gpg-suite*`, `mailsteward`) and Music (`quakenotch`), which quit the user's app on uninstall and risk losing their work. - A cask shouldn't quit a system app, so treat these like the other Apple apps already in `APPLE_LAUNCHJOBS_REGEX`.
Contributor
issyl0
approved these changes
Oct 13, 2026
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Library/Homebrew/test/cask/ci/check_spec.rb (1)
44-51: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover
systemeventsandsystempreferencesin the fixture.The current fixture does not exercise these two existing
APPLE_LAUNCHJOBS_REGEXalternatives. Add both identifiers so removing either alternative causes this assertion to fail.Suggested fix
"application.com.apple.Safari.123", + "application.com.apple.systemevents.123", + "application.com.apple.systempreferences.123", "application.com.apple.TextEdit.123",
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
98dd16c4-cbd6-4a73-b473-51158dfef91a
📒 Files selected for processing (2)
Library/Homebrew/cask/ci/check.rbLibrary/Homebrew/test/cask/ci/check_spec.rb
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (19)
- GitHub Check: docker (x86_64 Ubuntu 26.04)
- GitHub Check: docker (x86_64 Ubuntu 24.04)
- GitHub Check: docker (arm64 Ubuntu 24.04)
- GitHub Check: docker (arm64 Ubuntu 26.04)
- GitHub Check: workflow_syntax
- GitHub Check: tests (macOS, 2/2)
- GitHub Check: tests (generic OS, 1/2)
- GitHub Check: tests (online, 2/2)
- GitHub Check: tests (load-only macOS)
- GitHub Check: tests (macOS, 1/2)
- GitHub Check: tests (no Sorbet)
- GitHub Check: tests (generic OS, 2/2)
- GitHub Check: tests (load-only Linux)
- GitHub Check: tests (Linux, 2/2)
- GitHub Check: tests (online, 1/2)
- GitHub Check: tests (Linux, 1/2)
- GitHub Check: docs
- GitHub Check: syntax
- GitHub Check: Analyze
🔇 Additional comments (2)
Library/Homebrew/cask/ci/check.rb (1)
18-19: LGTM!Library/Homebrew/test/cask/ci/check_spec.rb (1)
44-51: LGTM!
4 of 9 tasks
krehel
approved these changes
Oct 13, 2026
Member
|
Good idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typinatoropens its tutorial.rtfdin TextEdit, which fails CI withcom.apple.TextEditleft running.uninstall quit:stanzas for Help Viewer (eaglefiler), Mail (gpg-suite*,mailsteward) and Music (quakenotch). But system apps should not be quit during uninstall.APPLE_LAUNCHJOBS_REGEX.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude with Opus 5.5 at High effort, with local review and testing.