Repository navigation
Use runtime platform for vendored gem extensions - #24159
Merged
Merged
Conversation
- Resolve native extensions with `Gem::Platform.local` so installed gems load their matching binaries on Linux and macOS. - Preserve the portable paths when regenerating `setup.rb`. Fixes #24158
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
setup.rb can raise NameError when loaded without RubyGems.
Review effort: Lite
Findings: None
What changed in this PR
Updates vendored Bundler paths to use the runtime platform for native extensions.
Changes:
- Uses
Gem::Platform.localfor extension paths. - Preserves dynamic paths during regeneration.
- Adds runtime-platform test coverage.
- A critical RubyGems-disabled loading issue remains unresolved.
| File | Description |
|---|---|
Library/Homebrew/vendor/bundle/bundler/setup.rb |
Uses runtime platform paths; requires a fallback when RubyGems is unavailable. |
Library/Homebrew/test/dev-cmd/vendor-gems_spec.rb |
Tests platform-specific extension paths. |
Library/Homebrew/dev-cmd/vendor-gems.rb |
Preserves dynamic paths during regeneration. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MikeMcQuaid
enabled auto-merge
October 3, 2026 20:29
krehel
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gem::Platform.localso installed gems load their matching binaries on Linux and macOS.setup.rb.Fixes #24158
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.