Repository navigation
formulary: link tap issues when formulae print - #24156
Merged
Merged
Conversation
MikeMcQuaid
enabled auto-merge
October 3, 2026 10:34
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add coverage and message assertions for the third-party tap branch.
Review effort: Lite
Findings: 1
What changed in this PR
Updates formula-load warnings to include the relevant tap’s issue-reporting URL.
Changes:
- Adds official and third-party tap guidance to warnings.
- Adds regression coverage for Homebrew Core.
| File | Changes |
|---|---|
Library/Homebrew/test/formulary_spec.rb |
Tests the Homebrew Core issue URL. |
Library/Homebrew/formulary.rb |
Adds tap-specific issue guidance to load warnings. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Formulary.load_formulawarns when a formula prints to stdout while loading, but does not say where to report it. This addresses the TODO from #20226.The warning now includes the tap's issues URL when available, using the appropriate message for official and third-party taps. Otherwise, the warning remains unchanged.
I kept this as a warning rather than an error because raising from
ensurewould prevent otherwise loadable formulae from loading. The suggestion in #20226 also ended with a warning shown to the user.Added a test for the
homebrew/coreissues URL.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code helped me pick this
TODO, wrote the test and drafted this description.I wrote the fix myself, reviewed the change and ran
brew lgtmlocally.