Repository navigation
Deduplicate combined upgrade summaries - #24149
Merged
Merged
Conversation
- Combine requested and dependent upgrades without duplicates so the confirmation plan and download heading use the same ordered list. - Preserve distinct versioned formulae. Fixes #24147
krehel
approved these changes
Oct 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Deduplicates combined upgrade summaries while preserving order and distinct versioned formulae.
Changes:
- Deduplicates combined upgrade entries.
- Adds regression coverage for ordering and download headings.
| File | Description |
|---|---|
Library/Homebrew/test/cmd/upgrade_spec.rb |
Tests ordering and duplicate removal. |
Library/Homebrew/cmd/upgrade.rb |
Deduplicates combined upgrade summaries. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24147
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.