Repository navigation
Handle unresolved Cask effective groups - #24146
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The application spec has unresolved Linux expectations and cache-reset issues.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates Caskroom group handling for unresolved effective GIDs and prevents unsafe group-write permissions.
Changes:
- Adds numeric GID fallback and ownership checks.
- Restricts permissions for unresolved or shared groups.
- Adds regression coverage.
| File | Summary |
|---|---|
Library/Homebrew/test/cask/caskroom_spec.rb |
Tests unresolved and numeric group handling. |
Library/Homebrew/test/cask/artifact/app_spec.rb |
Adds unresolved-GID coverage; requires cache reset and platform-specific expectations. |
Library/Homebrew/cask/caskroom.rb |
Implements numeric GID fallback and safe permission handling. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
4 tasks done
- Preserve the effective GID for missing AD/mobile group records. - Prevent group writes for `staff` and unresolved Caskroom groups. Fixes #24140
MikeMcQuaid
force-pushed
the
cask-unresolved-group
branch
from
October 1, 2026 10:21
bad5b24 to
d691306
Compare
MikeMcQuaid
enabled auto-merge
October 1, 2026 11:45
krehel
approved these changes
Oct 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

staffor unresolved Caskroom groups.Fixes #24140
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6.1 Sol at Extra High effort, with local review and testing.