[MikeMcQuaid]

• Keep the cleanup test lock alive and exercise garbage collection.
• Use bottle URLs with known cache filenames to avoid network timeouts.
• Reject HTTP header lookups in the checksum tests.

---

• Have you followed our Contributing guidelines?
• Have you checked for other open Pull Requests for the same change?
• Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
• Have you explained why you'd like these changes included, not just what they do?
• For bug fixes, have you given step-by-step brew commands to reproduce the bug?
• Have you written new tests (excluding integration tests)? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) locally?

---

• I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at Extra High effort, with local review and testing.

---

[Copilot]

Copilot review overview

🟢 Approval recommended

No unresolved issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Fixes flaky cleanup and bottle tests by preserving lock lifetimes and avoiding network-dependent lookups.

Changes:

• Keeps the cleanup lock open during garbage collection.
• Uses deterministic bottle cache paths.
• Prevents checksum tests from performing HTTP header lookups.

File	Description
Library/​Homebrew/​test/​cleanup_spec.rb	Stabilizes locked-file cleanup coverage.
Library/​Homebrew/​test/​bottle_spec.rb	Makes bottle cache and checksum tests deterministic.

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[krehel]

Thanks!