Repository navigation
Prevent SSH prompts during sandboxed Git fetches - #24117
Merged
Merged
Conversation
- Fail promptly when SSH cannot decrypt a private key instead of waiting for input hidden by concurrent download output. - Preserve sandbox permissions and existing SSH agent support. Fixes #24115
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Prevents sandboxed Git fetches from hanging on SSH passphrase prompts while preserving SSH agent support.
Changes:
- Forces non-interactive SSH askpass failures.
- Adds regression coverage for encrypted SSH keys and environment preservation.
| File | Description |
|---|---|
Library/Homebrew/test/download_strategies/git_spec.rb |
Tests prompt-free SSH failure behavior and preserved environment values. |
Library/Homebrew/download_strategy/git_download_strategy.rb |
Configures non-interactive SSH handling during sandboxed fetches. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MikeMcQuaid
enabled auto-merge
September 29, 2026 10:49
carlocab
approved these changes
Sep 29, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24115
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.