Skip to content

docs/_layouts/base.html: fix heading permalinks - #24116

Merged
MikeMcQuaid merged 1 commit into
mainfrom
docs-heading-permalinks
Sep 29, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
docs-heading-permalinks

Conversation

@bevanjkay

Copy link
Copy Markdown
Member

The anchor-js selector was copied from brew.sh and targets #page, which doesn't exist in the docs layout. Docs content renders inside #default, so update the selector so that it applies correctly across the docs site.

This functionality used to exist, however it was broken earlier in the year with a modernisation of the deployment;
6feb6f1


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

I used Opus 5 High to generate the fix.

The anchor-js selector was copied from brew.sh and targets #page, which
doesn't exist in the docs layout. Docs content renders inside #default,
so no page on docs.brew.sh had heading permalinks.
Copilot AI lite review requested due to automatic review settings September 29, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The targeted selector fix resolves the documented permalink issue with no unresolved review comments.

Review effort: Lite
Findings: None

What changed in this PR

Fixes documentation heading permalinks by targeting the correct #default content container.

Changes:

  • Updates the Anchor.js selector from #page to #default.
File Description
docs/​_layouts/​base.html Corrects the heading selector used by Anchor.js.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@bevanjkay
bevanjkay marked this pull request as draft September 29, 2026 09:22
@bevanjkay
bevanjkay marked this pull request as ready for review September 29, 2026 09:22

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 29, 2026
Merged via the queue into main with commit 4e9153e Sep 29, 2026
53 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the docs-heading-permalinks branch September 29, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址