Repository navigation
docs/_layouts/base.html: fix heading permalinks - #24116
Merged
Merged
Conversation
The anchor-js selector was copied from brew.sh and targets #page, which doesn't exist in the docs layout. Docs content renders inside #default, so no page on docs.brew.sh had heading permalinks.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted selector fix resolves the documented permalink issue with no unresolved review comments.
Review effort: Lite
Findings: None
What changed in this PR
Fixes documentation heading permalinks by targeting the correct #default content container.
Changes:
- Updates the Anchor.js selector from
#pageto#default.
| File | Description |
|---|---|
docs/_layouts/base.html |
Corrects the heading selector used by Anchor.js. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
bevanjkay
marked this pull request as draft
September 29, 2026 09:22
bevanjkay
marked this pull request as ready for review
September 29, 2026 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anchor-js selector was copied from brew.sh and targets #page, which doesn't exist in the docs layout. Docs content renders inside #default, so update the selector so that it applies correctly across the docs site.
This functionality used to exist, however it was broken earlier in the year with a modernisation of the deployment;
6feb6f1
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?I used Opus 5 High to generate the fix.