Repository navigation
Relocate prefixes split across x86-64 operands - #24080
Merged
Merged
Conversation
- Rewrite complete `movabs` prefix operands in ELF executable sections with separator padding to preserve instruction and suffix offsets. - Find split prefixes omitted from older bottle metadata and preserve hardlinks when rewriting affected files. - Share instruction encodings between discovery and rewriting to keep their matching rules consistent. Fixes #24074
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved relocation correctness and malformed-ELF handling issues remain.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates ELF binary relocation to handle x86-64 prefixes split across movabs operands while preserving offsets and hardlinks.
Changes:
- Rewrites split prefixes in executable ELF sections.
- Expands candidate discovery and preserves hardlinks.
- Adds regression tests and updates bottle compatibility documentation.
| File | Summary |
|---|---|
Library/Homebrew/test/keg_relocate/binary_relocation_spec.rb |
Adds relocation, architecture, section, and hardlink coverage. |
Library/Homebrew/keg_relocate.rb |
Implements split-prefix detection and relocation; has one critical and three moderate unresolved findings. |
docs/Bottles.md |
Documents prefix and cellar compatibility requirements. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
krehel
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

movabsprefix operands in ELF executable sections with separator padding to preserve instruction and suffix offsets.Fixes #24074
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.