Skip to content

Deduplicate deprecation and sandbox warnings - #24078

Merged
MikeMcQuaid merged 1 commit into
mainfrom
deduplicate-deprecation-warnings
Sep 23, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
deduplicate-deprecation-warnings

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Sep 23, 2026 •

Copy link
Copy Markdown
Member
  • Share a thread-safe opoo_once cache across warning callers.
  • Reserve Landlock warnings before forking to avoid duplicate output.
  • Replace the separate bottle metadata warning guard.
  • Preserve deprecation errors and distinct tap locations.

Fixes #24075
Closes #24079
Closes #24069.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at Extra High effort, with local review and testing.


Copilot AI lite review requested due to automatic review settings September 23, 2026 18:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Deduplicates deprecation warnings while preserving distinct tap locations and disabled-method errors.

Changes:

  • Adds process-local warning caching.
  • Deduplicates non-auditing warnings.
  • Adds coverage for caching, auditing, locations, and disabled methods.
File Description
Library/​Homebrew/​utils/​output.rb Caches emitted deprecation warnings.
Library/​Homebrew/​test/​utils/​output_spec.rb Tests deduplication and exception behavior.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@MikeMcQuaid
MikeMcQuaid force-pushed the deduplicate-deprecation-warnings branch from 8e2b69a to 601c3a6 Compare September 23, 2026 19:26
@MikeMcQuaid MikeMcQuaid changed the title Deduplicate deprecation warnings Deduplicate deprecation and sandbox warnings Sep 23, 2026
- Share a thread-safe `opoo_once` cache across warning callers.
- Reserve Landlock warnings before forking to avoid duplicate output.
- Replace the separate bottle metadata warning guard.
- Preserve deprecation errors and distinct tap locations.

Fixes #24075
Related to #24069.
@MikeMcQuaid
MikeMcQuaid force-pushed the deduplicate-deprecation-warnings branch from 601c3a6 to e43e524 Compare September 23, 2026 20:15
@MikeMcQuaid
MikeMcQuaid requested a review from a team as a code owner September 23, 2026 20:15
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit dfbd024 Sep 23, 2026
51 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the deduplicate-deprecation-warnings branch September 23, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning for the verified parameter in the url stanza is triggered several times for one occurrence

4 participants

⌂ 换网址