Repository navigation
Deduplicate deprecation and sandbox warnings - #24078
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Deduplicates deprecation warnings while preserving distinct tap locations and disabled-method errors.
Changes:
- Adds process-local warning caching.
- Deduplicates non-auditing warnings.
- Adds coverage for caching, auditing, locations, and disabled methods.
| File | Description |
|---|---|
Library/Homebrew/utils/output.rb |
Caches emitted deprecation warnings. |
Library/Homebrew/test/utils/output_spec.rb |
Tests deduplication and exception behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MikeMcQuaid
force-pushed
the
deduplicate-deprecation-warnings
branch
from
September 23, 2026 19:26
8e2b69a to
601c3a6
Compare
MikeMcQuaid
force-pushed
the
deduplicate-deprecation-warnings
branch
from
September 23, 2026 20:15
601c3a6 to
e43e524
Compare
krehel
approved these changes
Sep 23, 2026
MikeMcQuaid
enabled auto-merge
September 23, 2026 20:54
andrew
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opoo_oncecache across warning callers.Fixes #24075
Closes #24079
Closes #24069.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.