Skip to content

Clear the environment when reopening cask apps - #24057

Merged
MikeMcQuaid merged 1 commit into
mainfrom
cask-reopen-environment
Sep 21, 2026
Merged

Clear the environment when reopening cask apps#24057
MikeMcQuaid merged 1 commit into
mainfrom
cask-reopen-environment

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Sep 21, 2026

Copy link
Copy Markdown
Member

Let Launch Services supply the user's GUI environment, preventing Homebrew's TMPDIR override from breaking cross-process IPC.

Fixes #24055

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?
  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at Extra High effort, with local review and testing.

@MikeMcQuaid
Clear the environment when reopening cask apps
1b61c28 
- Let Launch Services supply the user's GUI environment, preventing
  Homebrew's `TMPDIR` override from breaking cross-process IPC.

Fixes #24055
Copilot AI lite review requested due to automatic review settings September 21, 2026 15:40
Copilot AI reviewed Sep 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 5709829 Sep 21, 2026
52 of 53 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the cask-reopen-environment branch September 21, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

macOS: cask app reopening leaks Homebrew's TMPDIR into GUI applications, breaking cross-process IPC

3 participants

@MikeMcQuaid @p-linnane
⌂ 换网址