Skip to content

Reconcile records for removed resources - #24049

Merged
p-linnane merged 1 commit into
mainfrom
advisory-record-reconciliation
Sep 21, 2026
Merged

p-linnane merged 1 commit into
mainfrom
advisory-record-reconciliation

Conversation

@p-linnane

Copy link
Copy Markdown
Contributor

--reconcile-history only revisits records that current matching still discovers, so a matched record whose resource was later removed from the formula keeps its ingestion-time fixed version forever. Query OSV for the stored registry resources as well, require every resource to be witnessed in formula history on each platform, and hold records whose upstream family is not rediscovered as resource_not_found or resource_not_rediscovered; these fallback queries rewrite or delete records, never create them, and daily matching is unchanged.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

OpenAI Codex drafted the change and tests; Claude Code (Fable 5.1) reviewed the diff. I reviewed the diff and commit message before pushing.


`--reconcile-history` only revisits records that current matching
still discovers, so a record whose resource was later dropped from the
formula kept its ingestion-time `fixed` version forever. Query OSV for
the stored registry resources as well, require every resource to be
witnessed in formula history on each platform, and hold records whose
upstream family is not rediscovered. These fallback queries rewrite or
delete records, never create them, and daily matching is unchanged.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copilot AI lite review requested due to automatic review settings September 21, 2026 04:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@p-linnane
p-linnane added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 1078481 Sep 21, 2026
53 of 54 checks passed
@p-linnane
p-linnane deleted the advisory-record-reconciliation branch September 21, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址