Repository navigation
Reconcile records for removed resources - #24049
Merged
Merged
Conversation
`--reconcile-history` only revisits records that current matching still discovers, so a record whose resource was later dropped from the formula kept its ingestion-time `fixed` version forever. Query OSV for the stored registry resources as well, require every resource to be witnessed in formula history on each platform, and hold records whose upstream family is not rediscovered. These fallback queries rewrite or delete records, never create them, and daily matching is unchanged. Signed-off-by: Patrick Linnane <patrick@linnane.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--reconcile-historyonly revisits records that current matching still discovers, so a matched record whose resource was later removed from the formula keeps its ingestion-timefixedversion forever. Query OSV for the stored registry resources as well, require every resource to be witnessed in formula history on each platform, and hold records whose upstream family is not rediscovered asresource_not_foundorresource_not_rediscovered; these fallback queries rewrite or delete records, never create them, and daily matching is unchanged.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex drafted the change and tests; Claude Code (Fable 5.1) reviewed the diff. I reviewed the diff and commit message before pushing.