Skip to content

Keep parsed and evaled stdout free of warnings - #24015

Merged
MikeMcQuaid merged 1 commit into
mainfrom
bundle_env_stderr
Sep 17, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
bundle_env_stderr

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • brew bundle env --check, exec --check and sh --check run the checker without redirecting stdout, so Skipping lines for entries in HOMEBREW_BUNDLE_*_SKIP or unsupported on the platform corrupted eval "$(brew bundle env --check)" and piped brew bundle check. Print them with opoo like other warnings, without a GitHub Actions annotation as they are routine, and let the OS prepends supply only the reason so the warning is printed in one place. Drop the unused silent: keyword.
  • brew update --auto-update runs before brew outdated --json and brew bundle env, so its custom Git remote and stashed changes hints now go to stderr like the rest of the update report.
  • Loading a cask from a URL printed ==> Downloading into brew info --json=v2 <url>, so guard it on a TTY like api.rb.
  • brew verify --json printed has a valid attestation before the JSON.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Claude with Fable 5.1 at Extra High effort, with local review and testing.


Copilot AI lite review requested due to automatic review settings September 17, 2026 10:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

- `brew bundle env --check`, `exec --check` and `sh --check` run the
  checker without redirecting stdout, so `Skipping` lines for entries in
  `HOMEBREW_BUNDLE_*_SKIP` or unsupported on the platform corrupted
  `eval "$(brew bundle env --check)"` and piped `brew bundle check`.
  Print them with `opoo` like other warnings, without a GitHub Actions
  annotation as they are routine, and let the OS prepends supply only
  the reason so the warning is printed in one place. Drop the unused
  `silent:` keyword.
- `brew update --auto-update` runs before `brew outdated --json` and
  `brew bundle env`, so its custom Git remote and stashed changes hints
  now go to stderr like the rest of the update report.
- Loading a cask from a URL printed `==> Downloading` into
  `brew info --json=v2 <url>`, so guard it on a TTY like `api.rb`.
- `brew verify --json` printed `has a valid attestation` before the JSON.
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit 0305e0b Sep 17, 2026
52 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the bundle_env_stderr branch September 17, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址