Repository navigation
Keep parsed and evaled stdout free of warnings - #24015
Merged
Merged
Conversation
- `brew bundle env --check`, `exec --check` and `sh --check` run the checker without redirecting stdout, so `Skipping` lines for entries in `HOMEBREW_BUNDLE_*_SKIP` or unsupported on the platform corrupted `eval "$(brew bundle env --check)"` and piped `brew bundle check`. Print them with `opoo` like other warnings, without a GitHub Actions annotation as they are routine, and let the OS prepends supply only the reason so the warning is printed in one place. Drop the unused `silent:` keyword. - `brew update --auto-update` runs before `brew outdated --json` and `brew bundle env`, so its custom Git remote and stashed changes hints now go to stderr like the rest of the update report. - Loading a cask from a URL printed `==> Downloading` into `brew info --json=v2 <url>`, so guard it on a TTY like `api.rb`. - `brew verify --json` printed `has a valid attestation` before the JSON.
MikeMcQuaid
force-pushed
the
bundle_env_stderr
branch
from
September 17, 2026 10:28
53750e4 to
4c330d7
Compare
MikeMcQuaid
enabled auto-merge
September 17, 2026 12:18
p-linnane
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew bundle env --check,exec --checkandsh --checkrun the checker without redirecting stdout, soSkippinglines for entries inHOMEBREW_BUNDLE_*_SKIPor unsupported on the platform corruptedeval "$(brew bundle env --check)"and pipedbrew bundle check. Print them withopoolike other warnings, without a GitHub Actions annotation as they are routine, and let the OS prepends supply only the reason so the warning is printed in one place. Drop the unusedsilent:keyword.brew update --auto-updateruns beforebrew outdated --jsonandbrew bundle env, so its custom Git remote and stashed changes hints now go to stderr like the rest of the update report.==> Downloadingintobrew info --json=v2 <url>, so guard it on a TTY likeapi.rb.brew verify --jsonprintedhas a valid attestationbefore the JSON.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude with Fable 5.1 at Extra High effort, with local review and testing.