Repository navigation
Derive service completions from Cellar paths - #24009
Merged
Merged
Conversation
Signed-off-by: Patrick Linnane <patrick@linnane.io>
MikeMcQuaid
enabled auto-merge
September 17, 2026 07:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew servicestab completion extracted the service name withawk -F'homebrew.|.service' '{print $3}'. That regex only worked for the legacyhomebrew.<name>files under/opt/homebrew, where the prefix supplied the extra match. It completes nothing for the currentsh.brew.<name>files, for custom service names, and for any prefix withouthomebrewin its path such as/usr/localor Linuxbrew.The Bash, fish and zsh completers now take the formula name from the Cellar directory (
$(NF-2)of the path) and deduplicate withsort -u, so multiple installed versions of a formula produce one entry. The generated completions are regenerated from the templates.To reproduce:
brew install postgresql@18, thenbrew services startand press tab. Nothing is completed before this change.Fixes #24006
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code (Fable 5.1) drafted the implementation and tests; I reviewed the diff, verified the new test fails without the fix and passes with it, and ran
brew lgtm --onlineplus targeted specs.