Skip to content

Add brew advisory-match --formula-list - #24007

Merged
MikeMcQuaid merged 1 commit into
mainfrom
advisory-formula-list
Sep 17, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
advisory-formula-list

Conversation

@p-linnane

Copy link
Copy Markdown
Contributor

A single --reconcile-history --all sweep over homebrew-core exceeded a CI job's limit and was cancelled with nothing saved. --formula-list=<file> lets a runner reconcile one newline-separated list of core formulae: it keeps bulk OSV queries, uses the Repology index without live per-formula fallbacks, deduplicates names, reports names no longer in core without loading them, never expands an empty list to the whole tap, and scopes the unvisited-record summary to the list. Ordinary matching and range decisions are unchanged.

Two added regressions confirm a repeat reconciliation leaves a corrected record byte-identical and does not recreate a deleted one. The advisory-database side partitions the lists by publication shard so each execution shard can be saved and retried independently.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

OpenAI Codex drafted the implementation and tests; Claude Code (Fable 5.1) reviewed the design and the diff. I reviewed the diff and commit message before pushing.


A single `--reconcile-history --all` sweep over homebrew-core exceeded a
CI job's limit and was cancelled with nothing saved. Let a runner
reconcile one newline-separated list of core formulae instead: keep
bulk OSV queries, use the Repology index without live per-formula
fallbacks, deduplicate names, report names no longer in core without
loading them, never expand an empty list to the whole tap, and scope
the unvisited-record summary to the list. Ordinary matching and range
decisions are unchanged.

Repeat reconciliation must be a no-op on already-corrected data: two
regressions confirm a corrected record stays byte-identical, including
its modified timestamp, and a deleted record is not recreated.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copilot AI lite review requested due to automatic review settings September 16, 2026 20:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit 2a833d2 Sep 17, 2026
51 of 52 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the advisory-formula-list branch September 17, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址