Repository navigation
Move NetworkSecurityClientTLSPolicy to identity and refs pattern - #8828
Conversation
… and refs pattern Move the NetworkSecurityClientTLSPolicy resource to the modern identity and refs pattern using gcpurls.Template and identity.IdentityV2. Fixes GoogleCloudPlatform#8818
| ObservedGeneration *int64 `json:"observedGeneration,omitempty"` | ||
|
|
||
| // A unique specifier for the NetworkSecurityClientTLSPolicy resource in GCP. | ||
| ExternalRef *string `json:"externalRef,omitempty"` |
There was a problem hiding this comment.
Never change the schema in this phase, we should only be bringing identity & reference types up to the latest conventions. Feel free to update the SKILL.md to clarify
There was a problem hiding this comment.
Thanks for the catch! I have reverted the schema change and removed ExternalRef from the Status. I've also updated the kcc-identity-reference SKILL.md to clarify this rule.
(This comment was generated by Overseer)
|
I've started a task to address the feedback on this PR. |
Investigating Presubmit failureRun: 26612750665(https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/26612750665) Investigating ci-presubmit failureRun: 26613655739(https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/26613655739) (This report was generated by Overseer) |
|
I have detected CI failures and triggered an investigation task. |
|
Overseer has triggered a task: . |
|
Overseer has triggered a task: |
Investigating Presubmit failureRun: 26612750665(https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/26612750665) Investigating ci-presubmit failureRun: 26613655739(https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/26613655739) (This report was generated by Overseer) |
| _ identity.Resource = &NetworkSecurityClientTLSPolicy{} | ||
| ) | ||
|
|
||
| var NetworkSecurityClientTLSPolicyIdentityFormat = gcpurls.Template[NetworkSecurityClientTLSPolicyIdentity]("networksecurity.googleapis.com", "projects/{project}/locations/{location}/clientTlsPolicies/{clienttlspolicy}") |
There was a problem hiding this comment.
I think the matching is case insensitive, but it reads better like this:
| var NetworkSecurityClientTLSPolicyIdentityFormat = gcpurls.Template[NetworkSecurityClientTLSPolicyIdentity]("networksecurity.googleapis.com", "projects/{project}/locations/{location}/clientTlsPolicies/{clienttlspolicy}") | |
| var NetworkSecurityClientTLSPolicyIdentityFormat = gcpurls.Template[NetworkSecurityClientTLSPolicyIdentity]("networksecurity.googleapis.com", "projects/{project}/locations/{location}/clientTlsPolicies/{clientTlsPolicy}") |
|
One nit about casing in the gcpurltemplate. |
…dentity and refs pattern
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
62ce64a
This PR moves the
NetworkSecurityClientTLSPolicyresource underapis/networksecurityto use the modern identity and reference pattern (identity.IdentityV2andrefs.Refusing thegcpurls.Templateapproach).Rationale and Changes
status.externalReffield: AddedExternalRef *stringtoNetworkSecurityClientTLSPolicyStatusstruct inapis/networksecurity/v1beta1/clienttlspolicy_types.go.dev/tasks/generate-types-and-mappersto updatezz_generated.deepcopy.goand the CRD definition underconfig/crds/resources/.clienttlspolicy_identity.go): Implemented theidentity.IdentityV2interface delegating togcpurls.Template.clienttlspolicy_reference.go): Implemented therefs.Refinterface and helper functions.This PR was generated by Overseer (powered by the gemini-3.5-flash model).
Fixes #8818