Repository navigation
Fix case sensitivity in SQLInstance availabilityType - #8025
Merged
anhdle-sso merged 1 commit intoMay 26, 2026
Merged
anhdle-sso merged 1 commit into
anhdle-sso merged 1 commit into
Conversation
himanigulati01
force-pushed
the
fix-sqlinstance-casing-drift
branch
2 times, most recently
from
May 11, 2026 06:51
19bc902 to
03b1c06
Compare
himanigulati01
force-pushed
the
fix-sqlinstance-casing-drift
branch
from
May 11, 2026 07:29
03b1c06 to
c10930a
Compare
Collaborator
|
/lgmt |
anhdle-sso
enabled auto-merge
May 26, 2026 20:59
anhdle-sso
approved these changes
May 26, 2026
anhdle-sso
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thank you
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anhdle-sso The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Merged
via the queue into
GoogleCloudPlatform:master
with commit May 26, 2026
0a6a878
169 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in SQLInstance where case sensitivity in .settings.availabilityType caused spurious drift and restarts. It uses strings.EqualFold for comparison and adds a unit test.
Internal bug ID: b/510919254