Skip to content

Fix case sensitivity in SQLInstance availabilityType - #8025

Merged
anhdle-sso merged 1 commit into
GoogleCloudPlatform:masterfrom
himanigulati01:fix-sqlinstance-casing-drift
May 26, 2026
Merged

anhdle-sso merged 1 commit into
GoogleCloudPlatform:masterfrom
himanigulati01:fix-sqlinstance-casing-drift

Conversation

@himanigulati01

@himanigulati01 himanigulati01 commented May 11, 2026 •

Copy link
Copy Markdown
Collaborator

This PR fixes a regression in SQLInstance where case sensitivity in .settings.availabilityType caused spurious drift and restarts. It uses strings.EqualFold for comparison and adds a unit test.

Internal bug ID: b/510919254

@himanigulati01
himanigulati01 force-pushed the fix-sqlinstance-casing-drift branch 2 times, most recently from 19bc902 to 03b1c06 Compare May 11, 2026 06:51
@himanigulati01
himanigulati01 force-pushed the fix-sqlinstance-casing-drift branch from 03b1c06 to c10930a Compare May 11, 2026 07:29
@himanigulati01
himanigulati01 requested a review from anhdle-sso May 25, 2026 08:18
@anhdle-sso

Copy link
Copy Markdown
Collaborator

/lgmt
/approve

@anhdle-sso
anhdle-sso enabled auto-merge May 26, 2026 20:59

@anhdle-sso anhdle-sso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you

@anhdle-sso
anhdle-sso added this pull request to the merge queue May 26, 2026
@google-oss-prow google-oss-prow Bot added the lgtm label May 26, 2026
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anhdle-sso
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Merged via the queue into GoogleCloudPlatform:master with commit 0a6a878 May 26, 2026
169 checks passed
@himanigulati01 himanigulati01 modified the milestones: 1.153.0, 1.152.0 May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址