Repository navigation
Allow updating userServiceAccountMapping in DataprocCluster - #7222
Conversation
|
--- INVESTIGATION REPORT ---
(This report was generated by Overseer) |
|
I've assigned a coding agent to investigate the CI failures in this PR. You can track progress in the sandbox kcc-pr-7222. (Overseer) |
|
--- INVESTIGATION REPORT ---
(This report was generated by Overseer) |
|
--- INVESTIGATION REPORT --- --- INVESTIGATION REPORT ---
(This report was generated by Overseer) |
|
I've assigned an agent to investigate the CI failures in this PR. You can track progress in the sandbox kcc-pr-7222. (Overseer) |
|
--- INVESTIGATION REPORT ---
(This report was generated by Overseer) |
|
--- INVESTIGATION REPORT --- --- INVESTIGATION REPORT --- (This report was generated by Overseer) |
| } | ||
|
|
||
| if ds, err := dcl.Diff(desired.Config, actual.Config, dcl.DiffInfo{ObjectFunction: compareClusterConfigNewStyle, EmptyObject: EmptyClusterConfig, OperationSelector: dcl.RequiresRecreate()}, fn.AddNest("Config")); len(ds) != 0 || err != nil { | ||
| if ds, err := dcl.Diff(desired.Config, actual.Config, dcl.DiffInfo{ObjectFunction: compareClusterConfigNewStyle, EmptyObject: EmptyClusterConfig, OperationSelector: dcl.TriggersOperation("updateClusterUpdateClusterOperation")}, fn.AddNest("Config")); len(ds) != 0 || err != nil { |
There was a problem hiding this comment.
Do we know what this does? Also the naming scheme seem broken or is it really meant to repeat itself like that :)
Ditto other cases below
There was a problem hiding this comment.
That's a strange method name but it's correct: https://github.com/GoogleCloudPlatform/declarative-resource-client-library/blob/main/services/google/dataproc/cluster_internal.go#L523
This method is used to build an UpdateCluster request to GCP, an example is the labels field: https://github.com/GoogleCloudPlatform/declarative-resource-client-library/blob/main/services/google/dataproc/cluster_internal.go#L7302
|
Tested the new CRD and DCL controller against realGCP and in my local cluster, I can successfully modify userServiceAccountMapping field. Monitored the resource in GCP and confirmed it's updated properly. Steps:
output from |
|
/test all |
|
@gemmahou: No presubmit jobs available for GoogleCloudPlatform/k8s-config-connector@master DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change removes the immutability constraint from 'config.securityConfig.identityConfig.userServiceAccountMapping' in DataprocCluster. It updates the DCL YAML schemas and the generated DCL Go code to support updates for this field. It also adds support for this field in MockGCP and includes a new test case to verify the update. Issue GoogleCloudPlatform#7171
…ormatting in MockGCP
- Fix mockgcp updateMask parsing for DataprocCluster to also accept the
camelCase field name config.securityConfig.identityConfig.userServiceAccountMapping.
KCC uses the declarative resource client library (DCL), which generates
patch updateMask based on KRM schema field names which are camelCase.
- Replace a hardcoded 'tempBucket' literal in dataproccluster-simple's
_http.log with ${dataStoreTempBucketPath} to match mockgcp normalization.
- Track _http.log and _generated_object_... for dataproccluster-update-usersa
test case.
9d1b9eb to
9a30d0b
Compare
f7cbfab to
2a1371f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldanielmadariaga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a8af1a6
This PR allows updating the
userServiceAccountMappingfield inDataprocClusterresources.The field was previously marked as immutable in both the DCL schema and the generated Go code, but GCP supports updating this field via the
patchmethod.Changes:
x-kubernetes-immutable: truefromconfig,securityConfig,identityConfig, anduserServiceAccountMappingin DCL YAML schemas (alpha, beta, GA).dcl.TriggersOperation("updateClusterUpdateClusterOperation")instead ofdcl.RequiresRecreate()for these fields.newUpdateClusterUpdateClusterRequestin DCL Go code to include theconfigfield in the update request body.userServiceAccountMappingin MockGCP.dataproccluster-update-usersato verify the update.Fixes #7171
This PR was generated by Overseer (powered by the gemini-3-flash-preview model).