Repository navigation
Fix: nil pointer dereference in alloydb direct controller - #5009
google-oss-prow[bot] merged 1 commit into
Conversation
|
Thank you Gemma! /lgtm |
yuwenma
left a comment
There was a problem hiding this comment.
The nil pointer part looks good. But I don't fully follow the change about UPDATE.
I would suggest adding a test to show it (and prove the change fix the issue)?
Suggest applying the "single feature per PR" rule especially since this is a bug fix |
8f9ca4f to
6545465
Compare
6545465 to
88f1263
Compare
yuwenma
left a comment
There was a problem hiding this comment.
/lgtm
/approve
We need test to verify the migration process itself (not migrated reconciler) work well. @maqiuyujoyce
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Agreed. This is on my radar. |
Change description
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
1.134
Please indicate the intended milestone.
Tests you have done
make ready-prto ensure this PR is ready for review.