Skip to content

feat(spanner): add samples for using multi-region encryption keys for backups and database - #4790

Merged
telpirion merged 3 commits into
mainfrom
spanner-mr-samples
Dec 9, 2024
Merged

telpirion merged 3 commits into
mainfrom
spanner-mr-samples

Conversation

@rahul2393

@rahul2393 rahul2393 commented Dec 7, 2024 •

Copy link
Copy Markdown
Contributor

Description

Reference PRs:

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@rahul2393
rahul2393 requested review from a team as code owners December 7, 2024 06:00
@snippet-bot

snippet-bot Bot commented Dec 7, 2024 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Dec 7, 2024

@telpirion telpirion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good! Some comments left. Consider adding a blank line inbetween logical groups of code.

@telpirion telpirion self-assigned this Dec 7, 2024
@rahul2393
rahul2393 requested a review from telpirion December 9, 2024 09:55
@telpirion
telpirion merged commit cb14eac into main Dec 9, 2024
@telpirion
telpirion deleted the spanner-mr-samples branch December 9, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址