Skip to content

fix(storage): remove forced DP for rapid and standard buckets to allow fallback to CloudPath - #5077

Merged
dangarhs merged 1 commit into
masterfrom
remove-forced-dp-headers
Sep 8, 2026
Merged

dangarhs merged 1 commit into
masterfrom
remove-forced-dp-headers

Conversation

@dangarhs

@dangarhs dangarhs commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

  • Remove forced DirectPath enforcement (force_direct_connectivity=ENFORCED) and mount-time verification probe for rapid and standard buckets, allowing requests to safely fall back to CloudPath when DirectPath is unavailable.
  • Remove obsolete DirectPath verification unit tests (TestCreateGRPCClientHandle_SkipDirectPathVerificationForRapid and TestCreateGRPCClientHandle_DirectPathVerificationForStandard) in internal/storage/storage_handle_test.go.
  • Update grpc_header_validation.yaml and emulator integration test assertions to remove the force_direct_connectivity=ENFORCED requirement.

Link to the issue in case of a bug fix.

b/556501068

Testing details

  1. Manual - NA
  2. Unit tests - Passed go test -v ./internal/storage -run TestStorageHandleTestSuite (68/68 passed).
  3. Integration tests - Verified via make build (go vet, golangci-lint, go build ./...).

Any backward incompatible change? If so, please explain.

No

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes DirectPath enforcement and connectivity verification for regional/non-rapid buckets, allowing fallback to CloudPath. This includes removing the enforcement configuration, verification logic, associated unit tests, and header validation assertions in integration tests. The feedback suggests cleaning up the now-unused verifyDirectPathConnectivity function and explicitly asserting the absence of the force_direct_connectivity=ENFORCED header in the integration tests to prevent regressions.

Comment thread internal/storage/storage_handle.go Resolved
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.76%. Comparing base (23cc49a) to head (ceb6971).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5077      +/-   ##
==========================================
- Coverage   86.87%   86.76%   -0.12%     
==========================================
  Files         176      176              
  Lines       18839    18832       -7     
==========================================
- Hits        16367    16340      -27     
- Misses       2471     2491      +20     
  Partials        1        1              
Flag Coverage Δ
unittests 86.76% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dangarhs
dangarhs marked this pull request as ready for review September 3, 2026 12:43
@dangarhs
dangarhs requested review from a team, anushka567 and meet2mky as code owners September 3, 2026 12:43
@github-actions github-actions Bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Sep 3, 2026
…w fallback to CloudPath

### Description
- Remove forced DirectPath enforcement (`force_direct_connectivity=ENFORCED`) and mount-time verification probe for rapid and standard buckets, allowing requests to safely fall back to CloudPath when DirectPath is unavailable.
- Remove obsolete DirectPath verification unit tests (`TestCreateGRPCClientHandle_SkipDirectPathVerificationForRapid` and `TestCreateGRPCClientHandle_DirectPathVerificationForStandard`) in `internal/storage/storage_handle_test.go`.
- Update `grpc_header_validation.yaml` and emulator integration test assertions to remove the `force_direct_connectivity=ENFORCED` requirement.

### Link to the issue in case of a bug fix.
b/556501068

### Testing details
1. Manual - NA
2. Unit tests - Passed `go test -v ./internal/storage -run TestStorageHandleTestSuite` (68/68 passed).
3. Integration tests - Verified via `make build` (`go vet`, `golangci-lint`, `go build ./...`).

### Any backward incompatible change? If so, please explain.
No
@dangarhs
dangarhs force-pushed the remove-forced-dp-headers branch from c27e499 to ceb6971 Compare September 3, 2026 12:57
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Hi @vadlakondaswetha, @anushka567, @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

1 similar comment
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Hi @vadlakondaswetha, @anushka567, @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@dangarhs
dangarhs merged commit 676ba07 into master Sep 8, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址