Repository navigation
fix(storage): remove forced DP for rapid and standard buckets to allow fallback to CloudPath - #5077
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes DirectPath enforcement and connectivity verification for regional/non-rapid buckets, allowing fallback to CloudPath. This includes removing the enforcement configuration, verification logic, associated unit tests, and header validation assertions in integration tests. The feedback suggests cleaning up the now-unused verifyDirectPathConnectivity function and explicitly asserting the absence of the force_direct_connectivity=ENFORCED header in the integration tests to prevent regressions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5077 +/- ##
==========================================
- Coverage 86.87% 86.76% -0.12%
==========================================
Files 176 176
Lines 18839 18832 -7
==========================================
- Hits 16367 16340 -27
- Misses 2471 2491 +20
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…w fallback to CloudPath ### Description - Remove forced DirectPath enforcement (`force_direct_connectivity=ENFORCED`) and mount-time verification probe for rapid and standard buckets, allowing requests to safely fall back to CloudPath when DirectPath is unavailable. - Remove obsolete DirectPath verification unit tests (`TestCreateGRPCClientHandle_SkipDirectPathVerificationForRapid` and `TestCreateGRPCClientHandle_DirectPathVerificationForStandard`) in `internal/storage/storage_handle_test.go`. - Update `grpc_header_validation.yaml` and emulator integration test assertions to remove the `force_direct_connectivity=ENFORCED` requirement. ### Link to the issue in case of a bug fix. b/556501068 ### Testing details 1. Manual - NA 2. Unit tests - Passed `go test -v ./internal/storage -run TestStorageHandleTestSuite` (68/68 passed). 3. Integration tests - Verified via `make build` (`go vet`, `golangci-lint`, `go build ./...`). ### Any backward incompatible change? If so, please explain. No
c27e499 to
ceb6971
Compare
|
Hi @vadlakondaswetha, @anushka567, @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
1 similar comment
|
Hi @vadlakondaswetha, @anushka567, @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
Description
force_direct_connectivity=ENFORCED) and mount-time verification probe for rapid and standard buckets, allowing requests to safely fall back to CloudPath when DirectPath is unavailable.TestCreateGRPCClientHandle_SkipDirectPathVerificationForRapidandTestCreateGRPCClientHandle_DirectPathVerificationForStandard) ininternal/storage/storage_handle_test.go.grpc_header_validation.yamland emulator integration test assertions to remove theforce_direct_connectivity=ENFORCEDrequirement.Link to the issue in case of a bug fix.
b/556501068
Testing details
go test -v ./internal/storage -run TestStorageHandleTestSuite(68/68 passed).make build(go vet,golangci-lint,go build ./...).Any backward incompatible change? If so, please explain.
No