Repository navigation
Add missing "parallelism" variable to CTK Batch job template module. - #6313
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration option for the CTK Batch job template, enabling users to specify the parallelism level for their cloud batch jobs. This addition is particularly beneficial for managing array jobs more effectively by limiting concurrent task execution. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new parallelism variable to the batch-job-template module, allowing users to configure the maximum number of tasks that can run in parallel across a batch job. This change updates the Terraform variables, local configurations, the job template, and the README documentation. Feedback is provided to add a validation block to the parallelism variable to ensure it is a positive integer, preventing invalid configurations and potential API errors.
f239c1c to
ad6e66e
Compare
shubpal07
left a comment
There was a problem hiding this comment.
+1 to @Neelabh94's comments regarding the plan-time barrier precondition and adding CI coverage in tools/validate_configs/test_configs/multiple-batch-jobs.yaml.
To complement that:
- Auto-fallback in
main.tf: Recommend settingparallelism = var.parallelism != null ? var.parallelism : (var.mpi_mode ? var.task_count : null)(mirroringtasks_per_nodeon line 25). This automatically handles the omission case in MPI jobs cleanly. - Precondition: Keep Neelabh's precondition in
local_file.job_templateto guard against explicit mismatches (parallelism != task_countwhenmpi_mode = true). - Docs: Update the description in
variables.tfand runmake terraform-format. - CI: Verify tests pass with
make validate_configsafter addingparallelism: 2tomultiple-batch-jobs.yaml.
…b=true; update var description; add test coverage
|
@shubpal07 and @Neelabh94, thanks for your reviews. I have applied your suggestions. |
|
/gcbrun |
|
this PR has been inactive for 2 days and has changes requested. @jacobw125, please address the requested changes or close the PR if it's no longer needed. |
|
This is a second reminder that this PR has been inactive for 5 days and has changes requested. @jacobw125, please address the requested changes or close the PR if it's no longer needed. |
3c0e878
into
GoogleCloudPlatform:develop
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.