Repository navigation
Ensure TableId includes project ID if not explicitly set - #1374
Conversation
Signed-off-by: Dominik Dębowczyk <dominik.debowczyk@getindata.com>
|
/gcbrun |
1 similar comment
|
/gcbrun |
davidrabinowitz
left a comment
There was a problem hiding this comment.
please run ./mvnw spotless:apply -Pall and push the new commit
Signed-off-by: Dominik Dębowczyk <dominik.debowczyk@getindata.com>
|
/gcbrun |
|
/gcbrun |
|
@ddebowczyk92 Please verify the change |
|
@davidrabinowitz LGTM. I verified it by running a Spark app with a JAR built from this PR, without specifying the project name in the table name. Below is a part of the generated OpenLineage event: |
|
/gcbrun |
|
@ddebowczyk92 the integration test fails on the following error in DSv2: Is there a bug in ReflectionUtils? We no not shade |
Signed-off-by: Dominik Dębowczyk <dominik.debowczyk@getindata.com>
|
@davidrabinowitz I believe the issue stems from this change: #1370 — it's the same root cause as the duplicated inputs I mentioned here. Removing the BigQueryRelationProvider class resolves the issue; I tested it locally. The failure occurs because the support for BigQuery implemented directly in openlineage spark integration is meant for dsv1 connector version. |
|
/gcbrun |
|
Revert of #1370 was successfully tested on my machine, so I incorporated this revert into this PR. |
Signed-off-by: Dominik Dębowczyk <dominik.debowczyk@getindata.com>
|
/gcbrun |
Solves #1373