Skip to content

Add proxy - #1

Merged
mfrister merged 13 commits into
masterfrom
add-proxy
Jul 17, 2018
Merged

mfrister merged 13 commits into
masterfrom
add-proxy

Conversation

@mfrister

Copy link
Copy Markdown
Contributor

See README on how this works.

@mfrister
mfrister requested a review from sbrandtb July 10, 2018 11:19

@mfrister mfrister left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from reviewing this together this with @sbrandtb.

Comment thread LICENSE
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, reading the paragraph above, these are only instructions on how to apply the license to source code, so these fields are rightly not filled in.

Comment thread main.go
authCookieCh <- c
break
}
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return error message if cookie not found

Comment thread main.go Outdated
)

func main() {
proxyAddr := "127.0.0.1:8124"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make dynamic

Better to tell users about the problem than just doing nothing.
The auth callback address must be fixed, so we can allow the
redirect_uri at the identity provider.
@mfrister
mfrister merged commit 7299aa4 into master Jul 17, 2018
@mfrister
mfrister deleted the add-proxy branch July 17, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址