Repository navigation
fix: fix update command - #18
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the update command by renaming the update function to updateExec, updating test assertions to use require for better failure reporting, and improving error wrapping and temporary file handling.
- Renamed the update command function for clarity
- Replaced assert with require in tests
- Updated error handling and temporary directory usage in the update process
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/update/update_test.go | Updated test assertions from assert to require |
| internal/update/update.go | Improved error wrapping and temporary directory handling in updates |
| internal/types/config.go | Modified error creation to use errors.Newf |
| internal/migration/graph_test.go | Switched test assertions from assert to require |
| internal/migration/definition_test.go | Replaced assert with require for improved test failure reporting |
| internal/graph/graph_test.go | Updated test assertions for consistency |
| cmd/kat/main.go | Changed the update command action from update to updateExec |
| cmd/kat/command.go | Renamed update function to updateExec and updated output formatting |
| README.md | Updated command usage information |
| AGENT.md | Added guideline note on using errors.New from cockroachdb/errors |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI
Manual testing