Skip to content

fix: fix update command - #18

Merged
BolajiOlajide merged 3 commits into
mainfrom
bo/fix-broken-update-cmd
May 20, 2025
Merged

BolajiOlajide merged 3 commits into
mainfrom
bo/fix-broken-update-cmd

Conversation

@BolajiOlajide

Copy link
Copy Markdown
Owner

CI
Manual testing

@BolajiOlajide BolajiOlajide self-assigned this May 20, 2025
@BolajiOlajide
BolajiOlajide requested a review from Copilot May 20, 2025 03:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the update command by renaming the update function to updateExec, updating test assertions to use require for better failure reporting, and improving error wrapping and temporary file handling.

  • Renamed the update command function for clarity
  • Replaced assert with require in tests
  • Updated error handling and temporary directory usage in the update process

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/update/update_test.go Updated test assertions from assert to require
internal/update/update.go Improved error wrapping and temporary directory handling in updates
internal/types/config.go Modified error creation to use errors.Newf
internal/migration/graph_test.go Switched test assertions from assert to require
internal/migration/definition_test.go Replaced assert with require for improved test failure reporting
internal/graph/graph_test.go Updated test assertions for consistency
cmd/kat/main.go Changed the update command action from update to updateExec
cmd/kat/command.go Renamed update function to updateExec and updated output formatting
README.md Updated command usage information
AGENT.md Added guideline note on using errors.New from cockroachdb/errors

Comment thread internal/update/update.go Resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@BolajiOlajide
BolajiOlajide merged commit 842de9b into main May 20, 2025
@BolajiOlajide
BolajiOlajide deleted the bo/fix-broken-update-cmd branch May 20, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址