Skip to content
This repository was archived by the owner on Oct 7, 2025. It is now read-only.

Add diskbuffer segment. - #78

Merged
ynHuber merged 2 commits into
BelWue:masterfrom
KIT-CERT:dev/diskbuffer
Feb 3, 2025
Merged

ynHuber merged 2 commits into
BelWue:masterfrom
KIT-CERT:dev/diskbuffer

Conversation

@JustKiddingCode

Copy link
Copy Markdown

Allows to buffer flows in memory and (additionally) on disk in zstd compressed files.

Add a small segment (filegate) for testing purposes to pause the pipeline when a file exists.

Allows to buffer flows in memory and (additionally) on disk in zstd
compressed files.

Add a small segment (filegate) for testing purposes to pause the pipeline when a file
exists.
@georg-e

georg-e commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Hi, thank you for the PR. I took a first look on it and have some comments and remarks to be adressed. Maybe you have already identified some of my points and maybe we need some more detailed testing and validation of this feature.

  • General structure and categorization:

    • i think the filegate segments suits better to the already existing testing directory/category instead of a new category like dev.
    • the new diskbuffer segment will be better categorized within the controlflow category. i think its rather an offloading and manipulation of the control-flow in the current flowpipeline instance
    • if possible, it would be nice to add some test cases to the segment. To start maybe a simple "passthrough" test for knowing, that the segment works and passes through flows. For an example please find pass_test.go
  • Diskbuffer segment

    • diskbuffer.go line 89 is probably reading the wrong configuration variable
    • it looks like data is still written to disk after filesize is reached. (after debug log in line 298 was triggered)

@ynHuber ynHuber mentioned this pull request Jan 29, 2025
ynHuber added a commit that referenced this pull request Feb 3, 2025
New Major Version v2

### Maintenance
- Moved GitHub orgs from bwNetFlow to BelWue @9er  #89
- Upgraded golang version to 1.23.2

### Bug fixes
- waitgroup in lumberjack segment. (@JustKiddingCode #79)
-  vacuum_interval for prometheus Export (@ynHuber #85)

### New segments
- diskbuffer (@JustKiddingCode #78)
- mongodb (@ynHuber #81)

### Breaking Changes:
- Protobuffer upgrade to match changes [introduced  in goflow2 v2.2.1](netsampler/goflow2@3326554) (@ynHuber  #86)
@ynHuber
ynHuber merged commit 41c2c8e into BelWue:master Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址