Repository navigation
fix: stop reporting locale and config objects as clones - #34
Merged
Merged
Conversation
… values as clones * A JS/TS object literal outside any function is data: its values must match for it to be a copy, as already required for arrays and maps * Found on a real app after file scope became the default: locale files sharing keys were reported as 2,600-line clones (27% -> 14.8% dup)
✅ PR title follows the required formatCurrent title: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Found by running the merged
mainon our own repositories before tagging a release.File scope (the new default) reported JS/TS locale files as clones of each other:
es.ts,ja-JP.tsand the rest share every key and differ only in the translated strings.How
An object literal outside any function (
const es = { … },export default { … },defineMessages({ … })) is data, so its values must match for it to count as a copy. Arrays, maps and PHP tables already worked this way; JS/TS objects were missed because{also opens a block.Checked
go test -race ./...,golangci-lint,govulncheckpass; the self-scan reports no duplicates.Not covered
Only JavaScript and TypeScript. Ruby hashes, Dart maps and Go struct literals outside functions can show the same pattern and are not handled here.