Skip to content
This repository was archived by the owner on Sep 30, 2026. It is now read-only.

fix: getting resultset metadata twice could skip row - #323

Merged
thiagotnunes merged 2 commits into
masterfrom
resultset-metadata-skips-row
Jan 17, 2021
Merged

thiagotnunes merged 2 commits into
masterfrom
resultset-metadata-skips-row

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

If the client application would call ResultSet#getMetaData() more than once before calling ResultSet#next(), the ResultSet would skip a row when the rows would be consumed.

Fixes #322

If the client application would call ResultSet#getMetaData() more than once
**before** calling ResultSet#next(), the ResultSet would skip a row when the
rows would be consumed.

Fixes #322
@olavloite
olavloite requested review from a team and thiagotnunes January 16, 2021 20:21
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Jan 16, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2021
@codecov

codecov Bot commented Jan 16, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #323 (3992298) into master (e1cd90d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #323      +/-   ##
============================================
+ Coverage     70.93%   70.99%   +0.05%     
- Complexity     1105     1107       +2     
============================================
  Files            24       24              
  Lines          3423     3423              
  Branches        526      526              
============================================
+ Hits           2428     2430       +2     
+ Misses          780      778       -2     
  Partials        215      215              
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/spanner/jdbc/JdbcResultSet.java 74.79% <100.00%> (+0.54%) 188.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1cd90d...3992298. Read the comment docs.

@thiagotnunes
thiagotnunes merged commit f8149af into master Jan 17, 2021
@thiagotnunes
thiagotnunes deleted the resultset-metadata-skips-row branch January 17, 2021 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling ResultSet#getMetaData() more than once before calling ResultSet#next() skips a row

2 participants

⌂ 换网址