Skip to content

sdk/resource: prevent nil MarshalLog panic - #8758

Merged
dashpole merged 6 commits into
open-telemetry:mainfrom
jstar0:fix/resource-marshal-log-nil
Aug 20, 2026
Merged

dashpole merged 6 commits into
open-telemetry:mainfrom
jstar0:fix/resource-marshal-log-nil

Conversation

@jstar0

@jstar0 jstar0 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Prevent Resource.MarshalLog from panicking when the resource is nil.

This keeps logging resilient for nil resources and adds a regression test in go.opentelemetry.io/otel/sdk/resource.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 15, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@codecov

codecov Bot commented Aug 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.1%. Comparing base (a17a4ae) to head (bfb52a5).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8758   +/-   ##
=====================================
  Coverage   84.1%   84.1%           
=====================================
  Files        331     331           
  Lines      26497   26499    +2     
=====================================
+ Hits       22296   22306   +10     
+ Misses      3796    3788    -8     
  Partials     405     405           
Files with missing lines Coverage Δ
sdk/resource/resource.go 86.9% <100.0%> (+0.2%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dashpole
dashpole merged commit 57b391a into open-telemetry:main Aug 20, 2026
51 checks passed
@pellared pellared mentioned this pull request Aug 24, 2026
pellared added a commit that referenced this pull request Aug 25, 2026
This release is the last to support [Go 1.25].
The next release will require at least [Go 1.26].

### Added

- Support testing of [Go 1.27]. (#8811)
- Support `http/json` protocol in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`.
(#8273, #8775, #8831)
- Add `Hasher` struct and methods in
`go.opentelemetry.io/otel/attribute` to compute authoritative `Distinct`
hashes incrementally for attribute filtering and deduplication. (#8598)

### Changed

- Lazily evaluate filtered and dropped attributes on measurement hot
paths in `go.opentelemetry.io/otel/sdk/metric` to avoid unnecessary
attribute set allocations. (#8598)
- Add `ErrExporterShutdown` to `go.opentelemetry.io/otel/sdk/log` and
return it from the
`go.opentelemetry.io/otel/exporters/stdout/stdoutlog`,
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`, and
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` exporters
when `Export` is called after `Shutdown`. (#8773)
- Clarify in `go.opentelemetry.io/otel/log` that calling
`Logger.Enabled` is optional and that cached results can become stale.
(#8764)

### Fixed

- Export dropped attribute counts in OTLP log records from
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc` and
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8829)
- Name span events created from OpenTracing logs after the `event` log
field, falling back to `log`, instead of always using an empty name in
`go.opentelemetry.io/otel/bridge/opentracing`. (#8648)
- Count exception attributes omitted due to the attribute count limit as
dropped in `go.opentelemetry.io/otel/sdk/log`. (#8796)
- Prevent log record and instrumentation scope attributes with empty
keys from reaching processors and exporters in
`go.opentelemetry.io/otel/sdk/log`. (#8797)
- Fix a data race when span attributes are read concurrently in
`go.opentelemetry.io/otel/sdk/trace`. (#8706)
- Prevent a panic in `(*Set).Filter` when called on a nil receiver in
`go.opentelemetry.io/otel/attribute`. (#8792)
- The simple span and log processors record
`otel.sdk.processor.{span,log}.processed` when the record is submitted
to the exporter instead of after the export completes, and no longer set
`error.type` from the export outcome, in
`go.opentelemetry.io/otel/sdk/trace` and
`go.opentelemetry.io/otel/sdk/log`. (#8705)
- Prevent `Resource.MarshalLog` from panicking on nil resources in
`go.opentelemetry.io/otel/sdk/resource`. (#8758)

[Go 1.27]: https://go.dev/doc/go1.27
[Go 1.26]: https://go.dev/doc/go1.26
[Go 1.25]: https://go.dev/doc/go1.25
@pellared pellared added this to the v1.46.0 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址