Skip to content

chore: bump node to v24.22.1 (45-x-y) - #55163

Merged
VerteDinde merged 4 commits into
45-x-yfrom
roller/node/45-x-y
Oct 22, 2026
Merged

VerteDinde merged 4 commits into
45-x-yfrom
roller/node/45-x-y

Conversation

@electron-roller

Copy link
Copy Markdown
Contributor

Updating Node.js to v24.22.1.

See all changes in v24.22.0..v24.22.1

Notes: Updated Node.js to v24.22.1.

@electron-roller
electron-roller Bot requested a review from a team as a code owner October 21, 2026 13:00
@electron-roller electron-roller Bot added backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Oct 21, 2026
Node.js v24.22.1 includes the upstream version of Electron's SPKI
blocklist patch, so tls_reject_chains_containing_blocked_public_keys.patch
no longer applies. Replace it with a smaller patch on top of the upstream
implementation that keeps the NODE_EXTERN test hooks used by Electron's
testing binding (spec/cert-revocation.spec.ts) and makes the new
CheckSPKIs() loop use OPENSSL_SIZE_T, since BoringSSL's sk_X509_num()
returns size_t.

Ref: nodejs/node#66871

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011amPfqBgESJFaWVNQhad62
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011amPfqBgESJFaWVNQhad62
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 02:22

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. It drops Electron's own TLS SPKI-blocklist patch and relies on code that is new in Node v24.22.1, and I can't see that code from this standalone clone, so a human look from patch-owners would still be worthwhile.

What was reviewed:

  • .patches swaps the deleted tls_reject_chains_containing_blocked_public_keys.patch for the new adapt patch, which has a subject and an explanatory body.
  • The NODE_EXTERN AddBlockedSPKIForTesting/ClearBlockedSPKIsForTesting signatures in the new patch match the declarations in shell/common/api/electron_api_testing.cc:49-50. spec/cert-revocation.spec.ts still exercises them.
  • I considered whether the BoringSSL sign-compare fix belongs in the existing BoringSSL compat patch. I didn't raise it, because it sits with the blocklist adaptation it serves.

Worth confirming against upstream v24.22.1: does Node's compiled-in list contain the same 8 SPKI hashes the old patch carried? And when no chain can be built, does it still fall back to checking the certificates the peer sent, as the old CertVerifyCallback did?

Extended reasoning...

The PR bumps node_version in DEPS and replaces a 167-line Electron patch that forced X509_V_ERR_CERT_REVOKED for blocked SubjectPublicKeyInfo hashes with a smaller patch. The new patch only fixes sign-compare and exports test hooks over upstream's list. This is TLS certificate-verification code, a security-sensitive surface. Whether protection is preserved depends entirely on upstream Node source, which isn't present in this standalone checkout. Both patches/ and DEPS are covered by CODEOWNERS entries, and the follow-up commits were made by an automated agent, so a human owner should confirm the upstream parity.

@VerteDinde
VerteDinde enabled auto-merge (squash) October 22, 2026 02:31
The test added with Node v24.22.1 builds a startup snapshot via --build-snapshot, which Electron's binary does not support (same as the existing parallel/test-snapshot entries).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011amPfqBgESJFaWVNQhad62

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@VerteDinde
VerteDinde merged commit 0141b6c into 45-x-y Oct 22, 2026
76 checks passed
@VerteDinde
VerteDinde deleted the roller/node/45-x-y branch October 22, 2026 04:00
@release-clerk

release-clerk Bot commented Oct 22, 2026

Copy link
Copy Markdown

Release Notes Persisted

Updated Node.js to v24.22.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址