Repository navigation
Fix for "invalid Schema.Elem 1; need *Schema or *Resource" - #3429
Merged
bflad merged 1 commit intoJun 27, 2018
Merged
Conversation
Collaborator
|
See also #2914. |
Contributor
Author
|
@ewbankkit Great, so this is already a known issue. Note that the linked PR misses the fix for |
bflad
approved these changes
Jun 27, 2018
bflad
left a comment
Contributor
There was a problem hiding this comment.
Everything fell into place for #2914 so this pull request was good to go as well. On top of master after #2914 the only real change here was fixing aws_glue_catalog_database, which passes acceptance testing. Thanks @squidfunk! 🚀
make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogDatabase'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueCatalogDatabase -timeout 120m
=== RUN TestAccAWSGlueCatalogDatabase_importBasic
--- PASS: TestAccAWSGlueCatalogDatabase_importBasic (13.32s)
=== RUN TestAccAWSGlueCatalogDatabase_full
--- PASS: TestAccAWSGlueCatalogDatabase_full (27.81s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 41.185s
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently trying to extract the schema from the AWS provider to build an autocomplete provider for Atom, but Terraform panics at this location: https://github.com/hashicorp/terraform/blob/3253367c64ace91aa0f6c3abaaae66721f9b88a3/helper/schema/core_schema.go#L42-L50
I tracked the error down and found that some element types don't have schema definitions attached to them but reference types directly, like this:
This fixes the error and seems consistent with the rest of the library:
This PR fixes all resources that trigger this error.