Repository navigation
Commit a463e8a
authored
test(bodies): cover the remaining typed JSON Lines branches (#2339)
* test(bodies): cover the remaining typed JSON Lines branches
Adds reflection request-builder and JsonLinesContent<T> tests to close the
Codecov patch-coverage gaps on PR #2338:
- FindAsyncJsonLinesElementType: a class implementing IAsyncEnumerable<T> is
found through GetInterfaces (rather than being that interface itself), and
a type implementing two distinct IAsyncEnumerable<> interfaces is treated
as ambiguous and returns null.
- JsonLinesContent<T>.MoveNextAsync: a stream whose FlushAsync throws while
the producer's next step is still pending propagates the failure only
after that step completes, so the enumerator is never disposed while it
is in flight.
Two lines remain uncovered and are genuinely unreachable, not contorted
around:
- JsonLinesContent<T>'s 2-arg SerializeToStreamAsync override: on
NET8_0_OR_GREATER, HttpContent's internal plumbing always invokes the
3-arg CancellationToken overload (verified empirically), so the 2-arg
override is dead code once both are overridden; it only matters on the
netfx targets that lack the 3-arg overload.
- The closing brace of the catch block in MoveNextAsync: that catch always
ends with 'throw;', so the sequence point for falling through the catch
normally can never fire.
* test(bodies): cover the .NET Framework serialize entry point and simplify the flush wait
* test(bodies): arm the flush failure only after the first element is written1 parent 0418743 commit a463e8a
3 files changed
Lines changed: 180 additions & 14 deletions
File tree
- src
- Refit
- tests/Refit.Tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
123 | 124 | | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
| 125 | + | |
134 | 126 | | |
135 | 127 | | |
136 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
137 | 140 | | |
138 | 141 | | |
139 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
22 | 28 | | |
23 | 29 | | |
24 | 30 | | |
| |||
229 | 235 | | |
230 | 236 | | |
231 | 237 | | |
232 | | - | |
| 238 | + | |
233 | 239 | | |
234 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
235 | 272 | | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
236 | 305 | | |
237 | 306 | | |
238 | 307 | | |
| |||
397 | 466 | | |
398 | 467 | | |
399 | 468 | | |
400 | | - | |
| 469 | + | |
401 | 470 | | |
402 | 471 | | |
403 | | - | |
| 472 | + | |
404 | 473 | | |
405 | 474 | | |
406 | 475 | | |
| |||
420 | 489 | | |
421 | 490 | | |
422 | 491 | | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
423 | 512 | | |
424 | 513 | | |
425 | 514 | | |
| |||
504 | 593 | | |
505 | 594 | | |
506 | 595 | | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
507 | 620 | | |
508 | 621 | | |
509 | 622 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
349 | 367 | | |
350 | 368 | | |
351 | 369 | | |
| |||
545 | 563 | | |
546 | 564 | | |
547 | 565 | | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
548 | 598 | | |
0 commit comments