Repository navigation
Commit 27ddca2
authored
fix(testing): restore .NET Framework targets for the testing packages (#4427)
## What kind of change does this PR introduce?
Fix.
## What is the new behavior?
`ReactiveUI.Testing` and `ReactiveUI.Testing.Reactive` ship `net462`,
`net472` and `net481` again, alongside the modern `net8.0` - `net11.0`
targets. Verified by packing both projects and listing the package
contents:
```
ReactiveUI.Testing.nupkg ReactiveUI.Testing.Reactive.nupkg
lib/net462 lib/net462
lib/net472 lib/net472
lib/net481 lib/net481
lib/net8.0 net9.0 net10.0 net11.0 lib/net8.0 net9.0 net10.0 net11.0
```
The .NET Framework public surface is byte-identical to the `net8.0`
baseline, so nothing is reduced on the older frameworks.
## What is the current behavior?
Closes #4420
Since v23 both packages set
`<TargetFrameworks>$(ReactiveUIModernTargets)</TargetFrameworks>`, which
is `net8.0;net9.0;net10.0;net11.0`. The `ReactiveUI` package they exist
to test targets `$(ReactiveUIFinalTargetFrameworks)`, which does include
`$(ReactiveUIFrameworkTargets)` (`net462;net472;net481`). So a project
on .NET Framework could reference ReactiveUI but not its testing
helpers.
Note for anyone reading the issue: it points at
`ReactiveUITestingTargets` in `Directory.Build.props`. That property is
a red herring here - it is consumed only by test projects under
`src/tests`, never by the shipped packages. The actual driver was
`ReactiveUIModernTargets` in the two csproj files.
## What might this PR break?
- No source changed, and no public API changed on any existing target
framework. The four modern TFM baselines regenerate byte-identically.
- The two packages now build three additional target frameworks each, so
pack and CI time grow slightly.
- `ReactiveUI.Testing.Reactive` pulls `Microsoft.Reactive.Testing` on
the new frameworks; it resolves and compiles clean on all three.
## Checklist
- [x] I have read the [Contribute
guide](https://www.reactiveui.net/contribute/index.html)
- [x] Tests have been added or updated (for bug fixes / features)
- [x] Docs have been added or updated (for bug fixes / features)
- [x] Changes target the `main` branch
- [x] PR title follows [Conventional
Commits](https://www.conventionalcommits.org/)
## Additional information
The PublicAPI baselines for the six new (project, TFM) pairs were
produced with the repo's own `tools/generate-publicapi.sh`, which the
tooling README already names as the step for "after adding a new target
framework to a tracked library". Running it over both projects
regenerated all 14 pairs; the eight pre-existing ones came back
unchanged, which is the check that the generator is deterministic here
and that no existing surface moved.
Verified on Linux:
- `dotnet build reactiveui.slnx -c Release -t:Rebuild` - 0 warnings, 0
errors.
- Both testing projects rebuild clean across all seven target
frameworks.
- 4216 tests pass across ReactiveUI.Tests, ReactiveUI.Tests.Reactive,
ReactiveUI.Testing.Tests and ReactiveUI.Builder.Tests.1 parent ad4b00c commit 27ddca2
14 files changed
Lines changed: 351 additions & 2 deletions
File tree
- src
- ReactiveUI.Testing.Reactive
- PublicAPI
- net462
- net472
- net481
- ReactiveUI.Testing
- PublicAPI
- net462
- net472
- net481
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
0 commit comments