Repository navigation
Commit e68c8a6
authored
feat!: move to StyleSharp analyzers and ReactiveUI 26, add ReactiveUI.Validation.Reactive (#990)
* feat!: move to StyleSharp analyzers and ReactiveUI 26, add ReactiveUI.Validation.Reactive
- Replace StyleCop.Analyzers and Roslynator with StyleSharp, PerformanceSharp and SecuritySharp, matching ReactiveUI.Binding.SourceGenerators.
- Fix every analyzer finding in the library, AndroidX, tests and samples.
- Update NuGet packages, including ReactiveUI 26 and TUnit 1.72.
- Use the WhenAnyValueUnsafe overloads where an expression is passed in, since ReactiveUI 26 only intercepts literal lambdas.
- Resolve the default formatter with GetServices. Containers that throw from GetService for an unregistered type then fall back to the default formatter (#979).
- Add ReactiveUI.Validation.Reactive, built from the same source against ReactiveUI.Reactive (#967).
- Track the public API with PublicApiSharp baselines in place of the Verify approval tests.
- Raise the MinVer floor to 8.0.
BREAKING CHANGE: Requires ReactiveUI 26. View model type parameters need a class constraint. Optional parameters on public methods and constructors are now overloads, so callers must recompile.
* fix(android): stop shipping the generated Resource class
- Set AndroidGenerateResourceDesigner to false for every Android target.
- The libraries ship no Android resources, so the designer only added an empty public Resource type.
* feat(androidx): add ReactiveUI.Validation.AndroidX.Reactive
- Build the AndroidX extensions a second time against ReactiveUI.AndroidX.Reactive and ReactiveUI.Validation.Reactive.
- Apps on ReactiveUI.Reactive get the TextInputLayout bindings under ReactiveUI.Validation.Reactive.Extensions.
* build: check out every text file with LF line endings
- Copy .gitattributes from ReactiveUI.Binding.SourceGenerators.
- A Windows checkout with core.autocrlf rewrites files to CRLF, and the line-ending analyzer then fails the Windows build.
* test: restore full line coverage
- Remove the validity subject in BasePropertyValidation. Nothing ever pushed a value into it.
- Bind ValidationContext properties by name. The generated ToProperty never runs the lambda, which left those lines uncovered.
- Cover the Dispose(false) paths, the parameterless overloads and the non-generic enumerators.1 parent 76e7ee6 commit e68c8a6
144 files changed
Lines changed: 15361 additions & 5648 deletions
File tree
- .github
- src
- ReactiveUI.Validation.AndroidX.Reactive
- PublicAPI/net10.0-android
- ReactiveUI.Validation.AndroidX
- Extensions
- PublicAPI/net10.0-android
- ReactiveUI.Validation.Reactive
- PublicAPI
- net10.0-android
- net10.0-ios
- net10.0-maccatalyst
- net10.0-macos
- net10.0-tvos
- net10.0-windows10.0.19041.0
- net10.0
- net462
- net472
- net481
- net8.0-windows10.0.19041.0
- net8.0
- net9.0-windows10.0.19041.0
- net9.0
- ReactiveUI.Validation
- Abstractions
- Collections
- Comparators
- Components
- Abstractions
- Contexts
- Extensions
- Formatters
- Abstractions
- Helpers
- Polyfills
- PublicAPI
- net10.0-android
- net10.0-ios
- net10.0-maccatalyst
- net10.0-macos
- net10.0-tvos
- net10.0-windows10.0.19041.0
- net10.0
- net462
- net472
- net481
- net8.0-windows10.0.19041.0
- net8.0
- net9.0-windows10.0.19041.0
- net9.0
- States
- ValidationBindings
- Abstractions
- samples
- AvaloniaApplication1.Desktop
- AvaloniaApplication1
- ViewModels
- Views
- LoginApp.Avalonia.Desktop
- LoginApp.Avalonia
- Services
- Views
- LoginApp.WinForms
- Services
- Views
- LoginApp.Wpf
- Services
- Views
- LoginApp
- Services
- ViewModels
- tests
- ReactiveUI.Validation.Reactive.Tests
- ReactiveUI.Validation.Tests
- API
- Models
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
38 | 12 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | 28 | | |
41 | 29 | | |
42 | 30 | | |
| |||
47 | 35 | | |
48 | 36 | | |
49 | 37 | | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | 38 | | |
61 | 39 | | |
62 | 40 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
219 | | - | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
220 | 222 | | |
221 | 223 | | |
222 | 224 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
219 | | - | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
220 | 222 | | |
221 | 223 | | |
222 | 224 | | |
| |||
0 commit comments